This repository was archived by the owner on Mar 4, 2021. It is now read-only.
Make Conformity Monkey Notify Based on owner tag value #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public void testForOwnerTag() { | ||
| List<AutoScalingGroup> asgList = createASGList(); | ||
| String[] asgNames = {ASG1, ASG2}; | ||
| AWSClient awsMock = createMockAWSClient(asgList, asgNames); |
Contributor
There was a problem hiding this comment.
I'm not following the logic for this test: an awsMock was created and setup but never used.
It appears this test just looks to see if the owner tags are present in the test list rather then testing if the AWSClusterCrawler is behaving as expected.
Contributor
Author
|
@ebukoski Yes, regarding the test I was going down a couple of different paths and then admittedly took a pretty cheesy pass at it. Is the newer test better? |
Contributor
|
Much better! Thanks for the work on this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conformity Monkey currently only notifies owner email addresses if they are listed in the properties files.
This change will enable notifications to the email address contained in the value of the GLOBAL_OWNER_TAGKEY when no owner is specified in the properties file. If the owner is specified in both, the properties file will take priority.