This repository was archived by the owner on Mar 4, 2021. It is now read-only.
REST API: Add event ID to list of chaos events #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to get the IDs of terminated EC2 instances after the fact. With this change, both `POST` and `GET` will return the same JSON fields for each event. For some reason, `eventID` (the EC2 instance ID) was missing when retrieving events via the REST API.
Contributor
Author
|
Looking at the broken test right now. |
Contributor
Author
|
Fixed the failing test. Accidentally also fixed another problem where the test checked for a field named Please take a look. |
Contributor
|
LGTM, thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get the IDs of terminated EC2 instances after the fact.
With this change, both
POSTandGETwill return the same JSON fields for each event. For some reason,eventID(the EC2 instance ID) was missing when retrieving events via the REST API.Before:
After: