This repository was archived by the owner on Mar 4, 2021. It is now read-only.
Apply the ASG Tag filtering on ASGCrawler #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NetflixOSS » SimianArmy » SimianArmy-pull-requests #53 SUCCESS |
|
SimianArmy-pull-requests #225 SUCCESS |
|
I just started looking at adding this same feature until I saw this PR. I see no changes over the last month in regards to this PR - Want to bring back attention here to see if it can be merged? |
Contributor
|
Apologies for taking so long to review this. |
Contributor
|
Nice feature, going to try it out on Tuesday. |
Contributor
|
@ssharifnabavi Nice feature indeed. Tested it today and it worked like a charm! Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Chaos Monkey does not support the filtering based on ASG's tag. This is a PR for adding the tag filtering based on the key and value for Chaos Monkey. Each ASG with that tag (key, value) will be nominated for termination.