Added the ability to fine-tune the probability on a per-ASG basis. #228
Conversation
|
NetflixOSS » SimianArmy » SimianArmy-pull-requests #43 SUCCESS |
|
SimianArmy-pull-requests #215 SUCCESS |
|
@lorin This is Chaos Monkey specific so you might want to review. |
|
any chance I could get a review @lorin ? thanks |
|
@jeffggardner Apologies for the delays in the review. I noticed a couple of very small issues (a typo and a question), I wrote those as comments on the commit. Once those are addressed, should be good to go. |
|
NetflixOSS » SimianArmy » SimianArmy-pull-requests #45 FAILURE |
|
SimianArmy-pull-requests #217 FAILURE |
|
SimianArmy-pull-requests #218 FAILURE |
|
NetflixOSS » SimianArmy » SimianArmy-pull-requests #46 FAILURE |
|
NetflixOSS » SimianArmy » SimianArmy-pull-requests #47 SUCCESS |
|
SimianArmy-pull-requests #219 SUCCESS |
|
@lorin Hey Lorin, thanks for the review. I corrected the code per your comments. |
Added the ability to fine-tune the probability on a per-ASG basis.
Because not all ASG are created equally, we needed a way to tune the killing of instances and didn't want to add an entry in chaos.properties for every new ASG. This PR allows you to add a tag to your ASG with the key "chaosMonkey.aggressionCoefficient" and that value will be multiplied by your effective probability for that ASG. For example if my ASG effective probability is 0.5, I can tag my Cassandra ASG's [as an example] with chaosMonkey.aggressionCoefficient=0.5 so that my Cassandra ASG's will have an effective probability of 0.25.