This repository was archived by the owner on Mar 4, 2021. It is now read-only.
Email regex fix #201
Merged
Email regex fix #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SimianArmy-pull-requests #189 SUCCESS |
|
NetflixOSS » SimianArmy » SimianArmy-pull-requests #17 SUCCESS |
Contributor
|
Can you add a test to demonstrate the fix? |
|
NetflixOSS » SimianArmy » SimianArmy-pull-requests #18 SUCCESS |
|
SimianArmy-pull-requests #190 SUCCESS |
Author
There was a problem hiding this comment.
this is the case that this PR addresses and that fails if tested on master:
Gradle suite > Gradle test > com.netflix.simianarmy.basic.chaos.TestBasicChaosEmailNotifier.testValidEmailAddresses FAILED
java.lang.AssertionError at TestBasicChaosEmailNotifier.java:101
Contributor
|
Thanks for adding the tests, looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Email regex is wrong as it doesn't allow dots before the + symbol. e.g. name.surname+other@example.com
:cobertura
BUILD SUCCESSFUL
Total time: 46.275 secs