This repository was archived by the owner on Mar 4, 2021. It is now read-only.
New rule: UntaggedRule #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SimianArmy-pull-requests #183 FAILURE |
|
NetflixOSS » SimianArmy » SimianArmy-pull-requests #11 FAILURE |
This rule will check if a configurable list of tags has been set. If not, the resource will be marked for deletion.
|
SimianArmy-pull-requests #184 SUCCESS |
|
NetflixOSS » SimianArmy » SimianArmy-pull-requests #12 SUCCESS |
Contributor
|
In janitor properties, UntaggedRule is set to enabled by default: This seems overly aggressive as unleashing this without first making sure your infrastructure is appropriately tagged will cause janitor to start cleaning up everything. Should we default it the other way to false so it isn't so destructive out-of the-box? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule will check if a configurable list of tags has been set. If not, the resource will be marked for deletion.