This repository was archived by the owner on Mar 4, 2021. It is now read-only.
Configurable Global Monkey owner tag key #191
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a user configurable Janitor Monkey OWNER_TAG_KEY
When a new leashed janitor monkey is run; there can be a situation where the expectedTerminationTime of the resource can be null (as per Issue Netflix#189). This ensures if it is null, that it won't call the java.util.Date functions which can't handle a null.
As requested in Netflix#178 you can now set your Key for the AWS owner tag in the simianarmy.properties file. Applies to all Monkeys. If not set defaults to "owner".
|
SimianArmy-pull-requests #181 SUCCESS |
|
NetflixOSS » SimianArmy » SimianArmy-pull-requests #9 SUCCESS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where-ever there was hardcoded "owner" or "creator" key for Instances, Snapshots, Volumes, ASGs then utilise a simian army global configuration of case-sensitive key for tag owner as per #178. Falls back to "owner" if not set.