NetflixOSS » SimianArmy » SimianArmy-pull-requests #1 SUCCESS
This pull request looks good

SimianArmy-pull-requests #173 SUCCESS
This pull request looks good

Thanks for the PR. I was wondering if you would be willing to generalize it a little bit so that there isn't special case code. I was thinking you could have a property with a list of tags to check existence of. Or even more ambitious, tag/value pairs that you check. That way anyone could set tags for things they want janitor monkey to ignore and your OpsWorks case would also be solved. What do you think?

I thought about making the ASG and OpsWorks checks work that way, but some comments in the InstanceCrawlerJanitor gave me pause. It doesn't just use the presence of the tag aws:autoscaling:groupName to determine if an instance has an ASG, it falls back to the "AutoScaling service" mapping of idToASGInstance (see InstanceJanitorCrawler.java):

// At most times the aws:autoscaling:groupName tag has the ASG name, but there are cases
// that the instance is not correctly tagged and we can find the ASG name from AutoScaling
// service.

If this is an older concern and we can support everything by just tag checks, I'm game to refactor a bit.

I like special casing OpsWorks because it is a special case 👍