This repository was archived by the owner on Mar 4, 2021. It is now read-only.
Add accountName to emails from Janitor Monkey #174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or monkey is running from its emails
Add accountname
|
SimianArmy-pull-requests #169 SUCCESS |
ebukoski
added a commit
that referenced
this pull request
Aug 11, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our issue was we were running multiple SimianArmy instances in multiple accounts, so we get multiple emails a day from Janitor Monkey and it was hard to determine which account the instances, ASG's, etc pertained to in each email. So we added an accountName variable that we could pass to each SimianArmy instance to help identify. This is a generic name that makes sense to the people familiar with the accounts in our case it is usually teamName_dev or prod.
So by setting src.main.resources.client.properties -
simianarmy.client.aws.accountNameyou can see an account identifier in the Janitor Monkey emails, it will send default if not set.We thought we'd post it back in case anyone else has a similar need.
Thanks
Danny