This repository was archived by the owner on Mar 4, 2021. It is now read-only.
fixed SES client uses us-east-1 by default and SimpleDB cannot have dashes in name #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Mar 23, 2015
- Mails were rejected because it said that the email adress was not verified. Turned out that janitor monkey always sends emails via us-east-1
- I created an AWS SimpleDB instance with CloudFormation. It contained dashes in the domain name which broke janitor monkey
|
SimianArmy-pull-requests #170 SUCCESS |
Contributor
|
The SES change is the same as PR #142 and I have the same comment: By using the result of region() for the SES client it is effectively pinned to the value of "simianarmy.client.aws.region". This is restrictive and overloads the original meaning of the property. Also this could break existing deployments if the SES client region and current SimianArmy region differ. Creating a new dedicated property would be a better solution. The SimpleDB change looks good. |
Contributor
|
Addressed by PR #202. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.