This repository was archived by the owner on Mar 4, 2021. It is now read-only.
only log properties that are safe to log #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the context logs all key/value pairs from the configuration. This also includes the AWS secret key. Writing the AWS secret key to the log file makes the log file security-critical, something we would like to avoid.
|
SimianArmy-pull-requests #161 SUCCESS |
ebukoski
added a commit
that referenced
this pull request
Jul 21, 2015
only log properties that are safe to log
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the context logs all key/value pairs from the configuration.
This also includes the AWS secret key and the vsphere password.
Writing the AWS secret key to the log file makes the log file
security-critical, something we would like to avoid.