Record the suffix-stripped version of termination events by the CloudFor... #140
Conversation
…FormationChaosMonkey to correctly respect maxTerminationsPerDay
|
SimianArmy-pull-requests #151 FAILURE |
|
The CloudFormationChaosMonkey overrides isMaxTerminationCountExceeded() to use the suffix-stripped version of the ASG name when evaluating targets in doMonkeyBusiness(). The termination events serialized into SDB do not have their groupName stripped of their CloudFormation suffix. This led to isMaxTerminationCountExceeded() always evaluating to false, and thus, multiple terminations for a single ASG each day. The most straightforward (and consistent) fix seems to be overriding terminateInstance() as well. |
|
SimianArmy-pull-requests #152 FAILURE |
…eInstance, so remove it from sendTerminationNotification. Otherwise, we perform the conversion twice.
|
SimianArmy-pull-requests #153 FAILURE |
|
Not sure why the cobertura report isn't getting generated. Looks like the target is being skipped, but I don't think that is related to my changes.
|
|
SimianArmy-pull-requests #163 SUCCESS |
…on_naming Record the suffix-stripped version of termination events by the CloudFor...
...mationChaosMonkey to correctly respect maxTerminationsPerDay