Add vSphere crawler only to crawl target application #139
Conversation
…g all VMs by parrent folder name makes too much chaos. Specifying all VMs under the same absolute folder path as a group is a more precise way to inject faulty into target applications. So I add a VsphereChaosCrawler to crawl only VMs under target folder.
|
SimianArmy-pull-requests #146 SUCCESS |
There was a problem hiding this comment.
Looks like all this logic can be replaced with:
if (privateKey == null) {
privateKey = config.getStrOrElse("simianarmy.chaos.ssh.password", null);
}
if (privateKey != null) {
this.sshCredentials = LoginCredentials.builder().user(sshUser).privateKey(privateKey).build();
}
or am I missing a case ?
There was a problem hiding this comment.
The logic is to use password instead of private key to build ssh credential When user doesn't specify simianarmy.chaos.ssh.key. Do you mean LoginCredentials.builder().user(sshUser).password(privateKey).build()? Because simianarmy.chaos.ssh.password is password so we can only build LoginCredentials like this LoginCredentials.builder().user(sshUser).password(privateKey).build().
|
Hi YiFeng First, thanks for your contribution! Don't mean to be nitpicking but please:
All in all the code looks good - please add the minor improvement specified Thanks again, On Sun, Oct 5, 2014 at 5:41 AM, CloudBees pull request builder plugin <
|
|
Hi, Nir I really appreciate your careful review. Sorry for my the spelling mistake on the variable names. I will change code according to above 4 comments. Thanks a lot! |
1. Declare the class members at the top of the class. 2. Correct spelling mistakes. 3. Add more documentations. 4. Add unit tests
|
SimianArmy-pull-requests #147 FAILURE |
|
SimianArmy-pull-requests #148 FAILURE |
|
SimianArmy-pull-requests #149 FAILURE |
|
Hi, Nir I recorded a demo of my patch and posted it to http://youtu.be/AnSrpk_thDE. Hope you don't mind it. class VSphereChaosCrawler is public, should be declared in a file named VSphereChaosCrawler.java FAILURE: Build failed with an exception. Thanks again |
|
SimianArmy-pull-requests #150 SUCCESS |
|
Hi, Nir I have fixed all the problems you pointed above. Please feel free to give your comments . Thanks. |
|
Hi, Nir Thanks again |
|
Hi Daniel, Sorry but I'm no longer one of the maintainers of the Simian Army. Regards, On Thu, Oct 16, 2014 at 10:19 PM, Yifeng Xiao notifications@github.com
|
|
Because of conflicts I tried a manual merge but there are compile errors. Please let us know if there is interest in getting this PR Merged, otherwise I will Close it. |
There is no similar ASG concept in vSphere as in AWS and auto grouping all VMs by parrent folder name makes over-chaos to the whole vSphere. Specifying all VMs under the same absolute folder path as a group is a more precise way to inject faulty into target applications. So I add a VsphereChaosCrawler to crawl only VMs under target folder.