This repository was archived by the owner on Mar 4, 2021. It is now read-only.
Refactor reading of chaos monkey properties and defaults values #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring out the reading of 'enabled', 'maxTerminationsPerDay', and 'probability' into a separate method. The method also handles reading the default values from the group level if one doesn't exist at the named group level. The reason for the refactor is to override the way defaults are read internally at netflix.
|
SimianArmy-pull-requests #132 SUCCESS |
|
Thanks cloud bees! merging. |
abasiri
added a commit
that referenced
this pull request
Apr 3, 2014
…-monkey-configuration-read Refactor reading of chaos monkey properties and defaults values
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring out the reading of 'enabled', 'maxTerminationsPerDay', and 'probability' into a separate method. The method also handles reading the default values from the group level if one doesn't exist at the named group level. The reason for the refactor is to override the way defaults are read internally at netflix.