This repository was archived by the owner on Mar 4, 2021. It is now read-only.
commenting out part of test that verifies DST cutover #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SimianArmy-pull-requests #130 SUCCESS |
|
+1, the other test that fails due to timezone is ./src/test/java/com/netflix/simianarmy/basic/TestBasicCalendar.java (Fails in our timezone) |
abasiri
added a commit
that referenced
this pull request
Apr 17, 2014
commenting out part of test that verifies DST cutover
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out my efforts to provide a proper unit test (using invariants) to check what happens during a DST cutover fails if the test is run in a zone like UTC (where DST is not observed). This happens because the tagging monkey does not include timezone info in its tag, so in the unit test, while I specify Los Angeles, when the date is parsed out of the tag by a VM running in UTC, it will fail.
The test has some value, so I commented it out and left the appropriate explanation. To re-activate it, there should be a mockable method that calculates Date values from tags in OldDetachedVolumeRule.