Email notification changes #68
Conversation
CloudFormationChaosMonkey class to enable email notifications when no-suffix group names are used. Modified BasicChaosMonkey and BasicChaosEmailNotifier classes to enable global email notifications. eg. simianarmy.chaos.notification.global.receiverEmail = test@email.com is used to enable global email notifications. Added corresponding unit test. Refactored TestChaosMonkeyContext to remove duplicate code
|
We'll follow this up with an update to the wiki to cover the email notification property items, both for owner emails and the global option. |
|
SimianArmy-pull-requests #27 SUCCESS |
There was a problem hiding this comment.
Can you change '!= null' to StringUtils.notBlank()? This way we can prevent that accidentally setting the global email to empty string stops emails to be sent.
|
Sorry about my late reply. I was OOO recently. I have added some comments there. |
[globalNotificationEnabled.properties] - separated group email notification logic from global email notification logic [BasicChaosMonkey.java, ChaosEmailNotifier.java, BasicChaosEmailNotifier.java] - added a counter in test context to track global email notifications [TestChaosMonkeyContext.java] - added an assert to verify count of global email notifications [TestBasicChaosMonkey.java -> testGlobalNotificationEnabled()]
|
SimianArmy-pull-requests #32 SUCCESS |
|
Hello, |
suggestion by michaelnflx) - Logging at INFO level when both global and group notifications are sent out to differential between them
|
SimianArmy-pull-requests #33 SUCCESS |
|
Hello, Thanks to michaelnflx for the feedback on nicktgr15 's original commits for this pull request. We believe we've addressed the issues you've raised by:
Hope this addresses the issues. Thanks, |
|
Looks good. |
Email notification changes
Hi,
We've made the following changes:
no-suffix group names are used.
global email notifications. eg.
simianarmy.chaos.notification.global.receiverEmail = test@email.comis used to enable global email notifications. Added corresponding unit
test.