Cloud Formation Auto Generated Names and ASG opt in/out #62
Conversation
|
Hi Dip, My suggestion would be to create a CloudFormationChaosMonkey that extends BasicChaosMonkey and override isGroupEnabled to ignore the random suffix on the ASG name. We would also need to change BasicMonkeyServer.getChaosMonkeyClass to be configurable (ie use simianarmy.client.chaos.class property to specify new monkey class at startup. -Cory |
|
Cool, I'll have a go at making the changes and submit a patch back. |
…gs in logical name - Added new CloudFormationChaosMonkey class to remove random string in ASG name - New method copyAs to InstanceGroup Interface - Added implemention for CopyAs to BasicInstanceGroup - Added basic tests.
- Added unit tests - Refactored getEffectiveProbability() to allow use of our override function
- Made chaos monkey class configurable via properties file
- Added CloudFormationChaosMonkey integration test
|
Added a pull request. If there are any issues let me know and I'll fix asap. |
|
SimianArmy-pull-requests #21 SUCCESS |
|
SimianArmy-pull-requests #22 SUCCESS |
…use it with CloudFormationChaosMonkey.
|
SimianArmy-pull-requests #23 SUCCESS |
|
SimianArmy-pull-requests #24 SUCCESS |
|
The changes look pretty good. Thanks for the contribution! |
Cloud Formation Auto Generated Names and ASG opt in/out
Hi
When using cloud formation, the ASG created has a random string appended, such as:
foo-my-app-MyAutoScalingGroup-1727U49KMHGUT
We are currently using the opt in feature with Chaosmonkey to select a subset of our ASGs for Chaosmonkey to target.
So we put 'simianarmy.chaos.ASG.foo-my-app-MyAutoScalingGroup-1727U49KMHGUT.enabled =1' into the properties file.
However this can be a little problematic as occasionally we update the stack. This creates a new random string as a suffix to the ASG name and causes the opt-in configuration to fail to match the previously matched ASG.
Is there a way we can use some kind of pattern matching and if not could we submit a patch to solve this problem.
Dip