This repository was archived by the owner on Mar 4, 2021. It is now read-only.
Added backticks(`) to domain name in simpleDB select query #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
names that do not contain only letters, numbers, underscores (_), or dollar symbols as documented at http://docs.aws.amazon.com/AmazonSimpleDB/latest/DeveloperGuide/QuotingRulesSelect.html
|
SimianArmy-pull-requests #17 SUCCESS |
Contributor
|
Looks good. There are some other places using SDB table name in queries. I will fix them later. |
michaelnflx
added a commit
that referenced
this pull request
May 13, 2013
Added backticks(`) to domain name in simpleDB select query
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After changing simianarmy.recorder.sdb.domain = SIMIAN_ARMY to simianarmy.recorder.sdb.domain = chaosmonkey-resources-SimpleDBDomain-XXXXXXXXXXXX I was getting the error message you can see at the bottom of this message.
Reading the AWS documentation (http://docs.aws.amazon.com/AmazonSimpleDB/latest/DeveloperGuide/QuotingRulesSelect.html) I found that:
Based on the above quote I added the missing backticks(`) to the simpleDB select query in order to be able to use dashes "-" in the domain name. Generally, custom domain names will be better supported now. I also had to update the corresponding test.