[bug fix] fix subtle bug from netflix/metaflow#2463 #2498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valayDave
added a commit
to valayDave/metaflow
that referenced
this pull request
Jul 22, 2025
When doing something like :
```
from metaflow import project
....
mymutableflow.add_decorator(
project, deco_kwargs={"name":"abc"})
```
Metaflow breaks with the error :
```
File ".../metaflow/flowspec.py", line 312, in _process_config_decorators
deco.pre_mutate(mutable_flow)
File "mydeco.py", line 67, in pre_mutate
mutable_flow.add_decorator(
File ".../metaflow/user_decorators/mutable_flow.py", line 409, in add_decorator
_add_flow_decorator(
File ".../metaflow/user_decorators/mutable_flow.py", line 353, in _add_flow_decorator
d for d in self._flow_cls._flow_decorators if d.name == flow_deco.name
^^^^^^
AttributeError: 'str' object has no attribute 'name'
```
This is because we dont parse the _flow_cls._flow_decorators in the right way (as a dict instead of list)
valayDave
added a commit
to valayDave/metaflow
that referenced
this pull request
Jul 25, 2025
When doing something like :
```
from metaflow import project
....
mymutableflow.add_decorator(
project, deco_kwargs={"name":"abc"})
```
Metaflow breaks with the error :
```
File ".../metaflow/flowspec.py", line 312, in _process_config_decorators
deco.pre_mutate(mutable_flow)
File "mydeco.py", line 67, in pre_mutate
mutable_flow.add_decorator(
File ".../metaflow/user_decorators/mutable_flow.py", line 409, in add_decorator
_add_flow_decorator(
File ".../metaflow/user_decorators/mutable_flow.py", line 353, in _add_flow_decorator
d for d in self._flow_cls._flow_decorators if d.name == flow_deco.name
^^^^^^
AttributeError: 'str' object has no attribute 'name'
```
This is because we dont parse the _flow_cls._flow_decorators in the right way (as a dict instead of list)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packaging PR #2463 introduced the
extract_args_kwargs_from_decorator_specto parse the decospecs added from the command line. This function has a subtle bug where it returns from the for loop instead of the end of the function.