Add dwExtraInfo to Event struct in Windows implementation #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update grab to use new eventtype make extra_info field windows-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to access the Windows-specific
dwExtraInfofield that comes in with each event when using the crate compiled for Windows.This changes the public API of the
Eventstruct by adding a conditionally fieldpub extra_info: u32on Windows targets.Cross-platform considerations
On macOS, there is a partial analogue (
kCGEventSourceUserData). Could be integrated if more cross-platform support is needed.On X11/Wayland, I did not find a clear parallel after surveying XInput2 and Wayland protocols. Input welcome if there’s a known equivalent.
I considered adding some kind of all-platform
user_datafield (Option<u32>) that isNoneon non-Windows, but decided against it to avoid implying consistent support across all platforms where it doesn’t exist.