Narsil · Narsil · Jun 23, 2025 · Jun 23, 2025 · Jun 23, 2025
diff --git a/src/linux/wayland/grab.rs b/src/linux/wayland/grab.rs
@@ -581,10 +581,7 @@ fn setup_inotify(epoll_fd: RawFd, devices: &[Device]) -> io::Result<Inotify> {
     //Ensure there is space for inotify at last epoll index.
     if devices.len() as u64 >= INOTIFY_DATA {
         eprintln!("number of devices: {}", devices.len());
-        return Err(io::Error::new(
-            io::ErrorKind::Other,
-            "too many device files!",
-        ));
+        return Err(io::Error::other("too many device files!"));
     }
     // Set up inotify to listen for new devices being plugged in
     let inotify = inotify_devices()?;

diff --git a/src/linux/wayland/keycodes.rs b/src/linux/wayland/keycodes.rs
@@ -153,7 +153,15 @@ decl_keycodes!(
     Kp7, 71,
     Kp8, 72,
     Kp9, 73,
-    KpDelete, 83
+    KpDelete, 83,
+    VolumeMute, 113,
+    VolumeDown, 114,
+    VolumeUp, 115,
+    NextTrack, 163,
+    PlayPause, 164,
+    PreviousTrack, 165,
+    PlayCd, 200,
+    Function, 464
 );
 
 #[rustfmt::skip]
@@ -259,7 +267,14 @@ decl_keycodes_uinput!(
     Key::Delete , UKey::Delete,
     Key::Pause , UKey::Pause,
     Key::MetaLeft , UKey::LeftMeta,
-    Key::PrintScreen , UKey::Print
+    Key::PrintScreen , UKey::Print,
+    Key::PlayPause, UKey::PlayPause,
+    Key::PlayCd, UKey::PlayCD,
+    Key::VolumeMute, UKey::Mute,
+    Key::VolumeDown, UKey::VolumeDown,
+    Key::VolumeUp, UKey::VolumeUp,
+    Key::NextTrack, UKey::NextSong,
+    Key::PreviousTrack, UKey::PreviousSong
     //Key::IntlBackslash , UKey::Backslash
 );
 

diff --git a/src/linux/wayland/listen.rs b/src/linux/wayland/listen.rs
@@ -73,6 +73,7 @@ fn convert(keyboard: &mut Keyboard, libevent: LibEvent) -> Option<Event> {
 
 impl LibinputInterface for Interface {
     fn open_restricted(&mut self, path: &Path, flags: i32) -> Result<OwnedFd, i32> {
+        #[allow(clippy::bad_bit_mask)]
         OpenOptions::new()
             .custom_flags(flags)
             .read((flags & O_RDONLY != 0) | (flags & O_RDWR != 0))

diff --git a/src/linux/wayland/xkb_keycodes.rs b/src/linux/wayland/xkb_keycodes.rs
@@ -3,5 +3,5 @@ use std::os::raw::c_uint;
 // Maps our internal keycodes to XKB keycodes
 pub fn internal_to_xkb_keycode(internal_code: c_uint) -> u32 {
     // XKB keycodes start at 8, so we need to offset them
-    internal_code as u32 + 8
+    internal_code + 8
 }
diff --git a/src/linux/x11/grab.rs b/src/linux/x11/grab.rs
@@ -516,10 +516,7 @@ fn setup_inotify(epoll_fd: RawFd, devices: &[Device]) -> io::Result<Inotify> {
     //Ensure there is space for inotify at last epoll index.
     if devices.len() as u64 >= INOTIFY_DATA {
         eprintln!("number of devices: {}", devices.len());
-        return Err(io::Error::new(
-            io::ErrorKind::Other,
-            "too many device files!",
-        ));
+        return Err(io::Error::other("too many device files!"));
     }
     // Set up inotify to listen for new devices being plugged in
     let inotify = inotify_devices()?;

diff --git a/src/rdev.rs b/src/rdev.rs
@@ -220,6 +220,15 @@ pub enum Key {
     Kp9,
     KpDelete,
     Function,
+    VolumeUp,
+    VolumeDown,
+    VolumeMute,
+    BrightnessUp,
+    BrightnessDown,
+    PreviousTrack,
+    PlayPause,
+    PlayCd,
+    NextTrack,
     Unknown(u32),
 }
 

diff --git a/src/windows/keycodes.rs b/src/windows/keycodes.rs
@@ -145,7 +145,13 @@ decl_keycodes! {
     Kp7, 103,
     Kp8, 104,
     Kp9, 105,
-    KpDelete, 110
+    KpDelete, 110,
+    VolumeMute, 173,
+    VolumeDown, 174,
+    VolumeUp, 175,
+    NextTrack, 176,
+    PreviousTrack, 177,
+    PlayPause, 179
 }
 
 #[cfg(test)]