Fix CapsLock handling of Keyboard for Windows.
#111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks a lot. I will trust you for now since you added a very nice test ! Thanks for the PR |
TTWNO
pushed a commit
to TTWNO/rdev2
that referenced
this pull request
Jan 23, 2025
Co-authored-by: adam <adam@org.org>
justDeeevin
pushed a commit
to justDeeevin/rdevin
that referenced
this pull request
Apr 16, 2025
Co-authored-by: adam <adam@org.org>
justDeeevin
pushed a commit
to justDeeevin/rdevin
that referenced
this pull request
Apr 16, 2025
Co-authored-by: adam <adam@org.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #110
The root cause of the bug is a misunderstanding of the
lpKeyStateargument ofToUnicodeEx. The MSDN says:Thus we should toggle the CapsLock state using the low bit.