Xlib horizontal wheel #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for your contribution. Don't have such a mouse at my disposal right now, but this is unlikely to break anything else so I will go ahead an merge if it passes the tests. |
Contributor
Author
|
Ah now I figured out how to run tests locally. I'll update here if I'm able to fix it. |
Contributor
Author
|
I also realized that there is an issue, when I tested on a view that is both horizontally and vertically scrollable at the same time (my earlier testing was done with one or another). Sorry for the broken PR! I'll attempt to fix this later today. |
Owner
|
No worries. Take your time. |
bd23fec to
aa2dd09
Compare
Contributor
Author
|
Fixed! Now in addition to implementing horizontal scrolling, I also implemented the scrolling magnitude for Linux as well. At least on my machine, now everything works well, including the tests. |
TTWNO
pushed a commit
to TTWNO/rdev2
that referenced
this pull request
Jan 23, 2025
justDeeevin
pushed a commit
to justDeeevin/rdevin
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for horizontal scrolling for Linux, tested on Pop!_OS 22.04.
Note that in
send_native, y-direction must be done first, or only one direction will trigger.I hope this helps!