Forgot to add `inline` in `is_address_from` #5349

fbusato · 2025-07-23T17:53:04Z

No description provided.

davebayer · 2025-07-23T18:19:20Z

I have one more idea - is it too late to chenge the order of the arguments? I was strongly for this order before, but I somehow don't like it anymore, I think it would make more sense to have the address first and then the address_space..

fbusato · 2025-07-23T18:23:38Z

this is an edge case. In general, this is considered a breaking change and not allowed. The functionality has been added in 3.0, but we documented it very recently. https://nvidia.github.io/cccl/libcudacxx/extended_api/memory/is_address_from.html
@bernhardmgruber what do you think about?

davebayer · 2025-07-23T18:24:55Z

this is an edge case. In general, this is considered a breaking change and not allowed. The functionality has been added in 3.0, but we documented it very recently. https://nvidia.github.io/cccl/libcudacxx/extended_api/memory/is_address_from.html @bernhardmgruber what do you think about?

I know. It was in 3.1 actually, so I am not sure whether it's too late for the change

github-actions · 2025-07-23T19:04:18Z

🟩 CI finished in 1h 08m: Pass: 100%/209 | Total: 1d 12h | Avg: 10m 24s | Max: 34m 30s | Hits: 97%/319261

🟩 cub: Pass: 100%/50 | Total: 11h 04m | Avg: 13m 16s | Max: 34m 27s | Hits: 99%/51848

🟩 cpu
  🟩 amd64              Pass: 100%/48  | Total: 10h 48m | Avg: 13m 31s | Max: 34m 27s | Hits:  99%/49322 
  🟩 arm64              Pass: 100%/2   | Total: 15m 18s | Avg:  7m 39s | Max:  8m 47s | Hits:  99%/2526  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  1h 04m | Avg: 12m 51s | Max: 34m 27s | Hits:  99%/6211  
  🟩 12.9               Pass: 100%/45  | Total:  9h 59m | Avg: 13m 19s | Max: 34m 14s | Hits:  99%/45637 
🟩 cudacxx
  🟩 ClangCUDA19        Pass: 100%/2   | Total: 10m 26s | Avg:  5m 13s | Max:  5m 19s | Hits:  99%/2175  
  🟩 nvcc12.0           Pass: 100%/5   | Total:  1h 04m | Avg: 12m 51s | Max: 34m 27s | Hits:  99%/6211  
  🟩 nvcc12.9           Pass: 100%/43  | Total:  9h 49m | Avg: 13m 42s | Max: 34m 14s | Hits:  99%/43462 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 26s | Avg:  5m 13s | Max:  5m 19s | Hits:  99%/2175  
  🟩 nvcc               Pass: 100%/48  | Total: 10h 53m | Avg: 13m 37s | Max: 34m 27s | Hits:  99%/49673 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 26m 05s | Avg:  6m 31s | Max:  7m 08s | Hits:  99%/5054  
  🟩 Clang15            Pass: 100%/2   | Total: 14m 00s | Avg:  7m 00s | Max:  7m 11s | Hits:  99%/2523  
  🟩 Clang16            Pass: 100%/2   | Total: 14m 38s | Avg:  7m 19s | Max:  7m 22s | Hits:  99%/2523  
  🟩 Clang17            Pass: 100%/2   | Total: 14m 06s | Avg:  7m 03s | Max:  7m 15s | Hits:  99%/2523  
  🟩 Clang18            Pass: 100%/2   | Total: 14m 03s | Avg:  7m 01s | Max:  7m 04s | Hits:  99%/2523  
  🟩 Clang19            Pass: 100%/7   | Total:  1h 20m | Avg: 11m 33s | Max: 26m 09s | Hits:  99%/5960  
  🟩 GCC7               Pass: 100%/2   | Total: 17m 09s | Avg:  8m 34s | Max:  8m 51s | Hits:  99%/2526  
  🟩 GCC8               Pass: 100%/1   | Total:  8m 18s | Avg:  8m 18s | Max:  8m 18s | Hits:  99%/1263  
  🟩 GCC9               Pass: 100%/2   | Total: 18m 49s | Avg:  9m 24s | Max:  9m 27s | Hits:  99%/2526  
  🟩 GCC10              Pass: 100%/2   | Total: 18m 22s | Avg:  9m 11s | Max:  9m 37s | Hits:  99%/2527  
  🟩 GCC11              Pass: 100%/2   | Total: 18m 11s | Avg:  9m 05s | Max:  9m 10s | Hits:  99%/2523  
  🟩 GCC12              Pass: 100%/2   | Total: 19m 13s | Avg:  9m 36s | Max:  9m 40s | Hits:  99%/2523  
  🟩 GCC13              Pass: 100%/12  | Total:  3h 08m | Avg: 15m 42s | Max: 31m 03s | Hits:  99%/7581  
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 04m | Avg: 32m 17s | Max: 34m 27s | Hits:  99%/2316  
  🟩 MSVC14.43          Pass: 100%/4   | Total:  2h 01m | Avg: 30m 21s | Max: 34m 14s | Hits:  99%/4632  
  🟩 NVHPC25.5          Pass: 100%/2   | Total: 25m 46s | Avg: 12m 53s | Max: 12m 59s | Hits:  98%/2325  
🟩 cxx_family
  🟩 Clang              Pass: 100%/19  | Total:  2h 43m | Avg:  8m 37s | Max: 26m 09s | Hits:  99%/21106 
  🟩 GCC                Pass: 100%/23  | Total:  4h 48m | Avg: 12m 32s | Max: 31m 03s | Hits:  99%/21469 
  🟩 MSVC               Pass: 100%/6   | Total:  3h 06m | Avg: 31m 00s | Max: 34m 27s | Hits:  99%/6948  
  🟩 NVHPC              Pass: 100%/2   | Total: 25m 46s | Avg: 12m 53s | Max: 12m 59s | Hits:  98%/2325  
🟩 gpu
  🟩 h100               Pass: 100%/3   | Total: 57m 51s | Avg: 19m 17s | Max: 31m 03s | Hits:  99%/1264  
  🟩 rtx2080            Pass: 100%/39  | Total:  7h 33m | Avg: 11m 37s | Max: 34m 27s | Hits:  99%/48058 
  🟩 rtxa6000           Pass: 100%/8   | Total:  2h 33m | Avg: 19m 08s | Max: 26m 09s | Hits:  99%/2526  
🟩 jobs
  🟩 Build              Pass: 100%/42  | Total:  7h 56m | Avg: 11m 21s | Max: 34m 27s | Hits:  99%/51848 
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 23m 58s | Avg: 23m 58s | Max: 23m 58s
  🟩 GraphCapture       Pass: 100%/1   | Total: 15m 45s | Avg: 15m 45s | Max: 15m 45s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 21m | Avg: 27m 13s | Max: 31m 03s
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 05m | Avg: 21m 55s | Max: 23m 22s
🟩 sm
  🟩 90                 Pass: 100%/3   | Total: 57m 51s | Avg: 19m 17s | Max: 31m 03s | Hits:  99%/1264  
  🟩 90;90a             Pass: 100%/2   | Total: 36m 20s | Avg: 18m 10s | Max: 28m 31s | Hits:  99%/2422  
  🟩 100;120            Pass: 100%/2   | Total: 35m 24s | Avg: 17m 42s | Max: 27m 06s | Hits:  99%/2422  
🟩 std
  🟩 17                 Pass: 100%/21  | Total:  4h 08m | Avg: 11m 48s | Max: 34m 27s | Hits:  99%/25915 
  🟩 20                 Pass: 100%/29  | Total:  6h 56m | Avg: 14m 20s | Max: 31m 36s | Hits:  99%/25933

🟩 thrust: Pass: 100%/50 | Total: 8h 52m | Avg: 10m 39s | Max: 32m 50s | Hits: 99%/84139

🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 14m 36s | Avg:  7m 18s | Max:  8m 35s | Hits:  99%/1914  
🟩 cpu
  🟩 amd64              Pass: 100%/48  | Total:  8h 40m | Avg: 10m 50s | Max: 32m 50s | Hits:  99%/80312 
  🟩 arm64              Pass: 100%/2   | Total: 12m 02s | Avg:  6m 01s | Max:  6m 54s | Hits:  99%/3827  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total: 52m 59s | Avg: 10m 35s | Max: 27m 41s | Hits:  99%/9560  
  🟩 12.9               Pass: 100%/45  | Total:  7h 59m | Avg: 10m 39s | Max: 32m 50s | Hits:  99%/74579 
🟩 cudacxx
  🟩 ClangCUDA19        Pass: 100%/2   | Total: 10m 56s | Avg:  5m 28s | Max:  5m 32s | Hits: 100%/3826  
  🟩 nvcc12.0           Pass: 100%/5   | Total: 52m 59s | Avg: 10m 35s | Max: 27m 41s | Hits:  99%/9560  
  🟩 nvcc12.9           Pass: 100%/43  | Total:  7h 48m | Avg: 10m 54s | Max: 32m 50s | Hits:  99%/70753 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 56s | Avg:  5m 28s | Max:  5m 32s | Hits: 100%/3826  
  🟩 nvcc               Pass: 100%/48  | Total:  8h 41m | Avg: 10m 52s | Max: 32m 50s | Hits:  99%/80313 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 23m 01s | Avg:  5m 45s | Max:  6m 05s | Hits: 100%/7652  
  🟩 Clang15            Pass: 100%/2   | Total: 11m 57s | Avg:  5m 58s | Max:  6m 11s | Hits: 100%/3826  
  🟩 Clang16            Pass: 100%/2   | Total: 12m 03s | Avg:  6m 01s | Max:  6m 19s | Hits: 100%/3826  
  🟩 Clang17            Pass: 100%/2   | Total: 11m 46s | Avg:  5m 53s | Max:  6m 01s | Hits: 100%/3826  
  🟩 Clang18            Pass: 100%/2   | Total: 12m 17s | Avg:  6m 08s | Max:  6m 09s | Hits: 100%/3826  
  🟩 Clang19            Pass: 100%/7   | Total: 40m 01s | Avg:  5m 43s | Max:  7m 01s | Hits: 100%/9565  
  🟩 GCC7               Pass: 100%/2   | Total: 14m 34s | Avg:  7m 17s | Max:  7m 23s | Hits:  99%/3828  
  🟩 GCC8               Pass: 100%/1   | Total:  7m 19s | Avg:  7m 19s | Max:  7m 19s | Hits:  99%/1914  
  🟩 GCC9               Pass: 100%/2   | Total: 14m 53s | Avg:  7m 26s | Max:  7m 53s | Hits:  99%/3828  
  🟩 GCC10              Pass: 100%/2   | Total: 15m 06s | Avg:  7m 33s | Max:  7m 49s | Hits:  99%/3828  
  🟩 GCC11              Pass: 100%/2   | Total: 15m 09s | Avg:  7m 34s | Max:  7m 39s | Hits:  99%/3828  
  🟩 GCC12              Pass: 100%/2   | Total: 16m 02s | Avg:  8m 01s | Max:  8m 18s | Hits:  99%/3828  
  🟩 GCC13              Pass: 100%/11  | Total:  1h 15m | Avg:  6m 50s | Max:  8m 35s | Hits:  99%/13398 
  🟩 MSVC14.29          Pass: 100%/2   | Total: 57m 05s | Avg: 28m 32s | Max: 29m 24s | Hits:  99%/3812  
  🟩 MSVC14.43          Pass: 100%/5   | Total:  2h 26m | Avg: 29m 23s | Max: 32m 50s | Hits:  99%/9530  
  🟩 NVHPC25.5          Pass: 100%/2   | Total: 59m 08s | Avg: 29m 34s | Max: 30m 15s | Hits:  99%/3824  
🟩 cxx_family
  🟩 Clang              Pass: 100%/19  | Total:  1h 51m | Avg:  5m 50s | Max:  7m 01s | Hits: 100%/32521 
  🟩 GCC                Pass: 100%/22  | Total:  2h 38m | Avg:  7m 11s | Max:  8m 35s | Hits:  99%/34452 
  🟩 MSVC               Pass: 100%/7   | Total:  3h 24m | Avg: 29m 09s | Max: 32m 50s | Hits:  99%/13342 
  🟩 NVHPC              Pass: 100%/2   | Total: 59m 08s | Avg: 29m 34s | Max: 30m 15s | Hits:  99%/3824  
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 13m 28s | Avg:  6m 44s | Max:  7m 14s | Hits:  99%/1914  
  🟩 rtx2080            Pass: 100%/38  | Total:  6h 43m | Avg: 10m 37s | Max: 30m 15s | Hits:  99%/72672 
  🟩 rtx4090            Pass: 100%/10  | Total:  1h 55m | Avg: 11m 31s | Max: 32m 50s | Hits:  99%/9553  
🟩 jobs
  🟩 Build              Pass: 100%/43  | Total:  7h 44m | Avg: 10m 48s | Max: 31m 24s | Hits:  99%/82233 
  🟩 TestCPU            Pass: 100%/3   | Total: 41m 16s | Avg: 13m 45s | Max: 32m 50s | Hits:  99%/1906  
  🟩 TestGPU            Pass: 100%/4   | Total: 26m 37s | Avg:  6m 39s | Max:  7m 14s
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 13m 28s | Avg:  6m 44s | Max:  7m 14s | Hits:  99%/1914  
  🟩 90;90a             Pass: 100%/2   | Total: 34m 20s | Avg: 17m 10s | Max: 27m 30s | Hits:  99%/3820  
  🟩 100;120            Pass: 100%/2   | Total: 31m 59s | Avg: 15m 59s | Max: 25m 02s | Hits:  99%/3820  
🟩 std
  🟩 17                 Pass: 100%/21  | Total:  3h 51m | Avg: 11m 00s | Max: 30m 12s | Hits:  99%/40160 
  🟩 20                 Pass: 100%/27  | Total:  4h 46m | Avg: 10m 37s | Max: 32m 50s | Hits:  99%/42065

🟩 libcudacxx: Pass: 100%/48 | Total: 9h 02m | Avg: 11m 17s | Max: 34m 30s | Hits: 95%/166873

🟩 cpu
  🟩 amd64              Pass: 100%/46  | Total:  8h 52m | Avg: 11m 34s | Max: 34m 30s | Hits:  95%/159410
  🟩 arm64              Pass: 100%/2   | Total:  9m 39s | Avg:  4m 49s | Max:  4m 57s | Hits:  98%/7463  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total: 48m 00s | Avg:  9m 36s | Max: 28m 07s | Hits:  97%/18292 
  🟩 12.9               Pass: 100%/43  | Total:  8h 14m | Avg: 11m 29s | Max: 34m 30s | Hits:  94%/148581
🟩 cudacxx
  🟩 ClangCUDA19        Pass: 100%/2   | Total: 55m 14s | Avg: 27m 37s | Max: 27m 43s | Hits:  28%/7427  
  🟩 nvcc12.0           Pass: 100%/5   | Total: 48m 00s | Avg:  9m 36s | Max: 28m 07s | Hits:  97%/18292 
  🟩 nvcc12.9           Pass: 100%/41  | Total:  7h 19m | Avg: 10m 42s | Max: 34m 30s | Hits:  98%/141154
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 55m 14s | Avg: 27m 37s | Max: 27m 43s | Hits:  28%/7427  
  🟩 nvcc               Pass: 100%/46  | Total:  8h 07m | Avg: 10m 35s | Max: 34m 30s | Hits:  98%/159446
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 21m 15s | Avg:  5m 18s | Max:  5m 56s | Hits:  97%/14810 
  🟩 Clang15            Pass: 100%/2   | Total: 11m 08s | Avg:  5m 34s | Max:  5m 52s | Hits:  98%/7423  
  🟩 Clang16            Pass: 100%/2   | Total: 11m 24s | Avg:  5m 42s | Max:  5m 54s | Hits:  98%/7423  
  🟩 Clang17            Pass: 100%/2   | Total: 13m 04s | Avg:  6m 32s | Max:  7m 25s | Hits:  96%/7423  
  🟩 Clang18            Pass: 100%/2   | Total: 10m 55s | Avg:  5m 27s | Max:  5m 37s | Hits:  98%/7423  
  🟩 Clang19            Pass: 100%/6   | Total:  1h 32m | Avg: 15m 29s | Max: 27m 43s | Hits:  75%/22312 
  🟩 GCC7               Pass: 100%/2   | Total:  9m 28s | Avg:  4m 44s | Max:  5m 03s | Hits:  98%/7359  
  🟩 GCC8               Pass: 100%/1   | Total:  4m 54s | Avg:  4m 54s | Max:  4m 54s | Hits:  98%/3690  
  🟩 GCC9               Pass: 100%/2   | Total: 10m 02s | Avg:  5m 01s | Max:  5m 09s | Hits:  98%/7371  
  🟩 GCC10              Pass: 100%/2   | Total: 10m 25s | Avg:  5m 12s | Max:  5m 31s | Hits:  98%/7425  
  🟩 GCC11              Pass: 100%/2   | Total: 10m 49s | Avg:  5m 24s | Max:  5m 38s | Hits:  98%/7421  
  🟩 GCC12              Pass: 100%/2   | Total: 10m 55s | Avg:  5m 27s | Max:  5m 33s | Hits:  98%/7425  
  🟩 GCC13              Pass: 100%/11  | Total:  2h 01m | Avg: 11m 04s | Max: 23m 06s | Hits:  98%/30191 
  🟩 MSVC14.29          Pass: 100%/2   | Total: 57m 59s | Avg: 28m 59s | Max: 29m 52s | Hits:  96%/7095  
  🟩 MSVC14.43          Pass: 100%/4   | Total:  2h 03m | Avg: 30m 48s | Max: 34m 30s | Hits:  98%/14673 
  🟩 NVHPC25.5          Pass: 100%/2   | Total: 22m 00s | Avg: 11m 00s | Max: 11m 09s | Hits:  98%/7409  
🟩 cxx_family
  🟩 Clang              Pass: 100%/18  | Total:  2h 40m | Avg:  8m 55s | Max: 27m 43s | Hits:  90%/66814 
  🟩 GCC                Pass: 100%/22  | Total:  2h 58m | Avg:  8m 06s | Max: 23m 06s | Hits:  98%/70882 
  🟩 MSVC               Pass: 100%/6   | Total:  3h 01m | Avg: 30m 12s | Max: 34m 30s | Hits:  97%/21768 
  🟩 NVHPC              Pass: 100%/2   | Total: 22m 00s | Avg: 11m 00s | Max: 11m 09s | Hits:  98%/7409  
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 28m 10s | Avg: 14m 05s | Max: 23m 06s | Hits:  98%/7630  
  🟩 rtx2080            Pass: 100%/46  | Total:  8h 34m | Avg: 11m 10s | Max: 34m 30s | Hits:  95%/159243
🟩 jobs
  🟩 Build              Pass: 100%/42  | Total:  7h 10m | Avg: 10m 15s | Max: 34m 30s | Hits:  95%/155553
  🟩 NVRTC              Pass: 100%/2   | Total: 42m 06s | Avg: 21m 03s | Max: 22m 12s | Hits:  90%/42    
  🟩 Test               Pass: 100%/3   | Total:  1h 07m | Avg: 22m 30s | Max: 23m 06s | Hits:  98%/11278 
  🟩 VerifyCodegen      Pass: 100%/1   | Total:  1m 47s | Avg:  1m 47s | Max:  1m 47s
🟩 sm
  🟩 75                 Pass: 100%/2   | Total: 42m 06s | Avg: 21m 03s | Max: 22m 12s | Hits:  90%/42    
  🟩 90                 Pass: 100%/2   | Total: 28m 10s | Avg: 14m 05s | Max: 23m 06s | Hits:  98%/7630  
  🟩 90;90a             Pass: 100%/2   | Total: 33m 27s | Avg: 16m 43s | Max: 28m 00s | Hits:  98%/7577  
  🟩 100;120            Pass: 100%/2   | Total: 35m 32s | Avg: 17m 46s | Max: 30m 12s | Hits:  98%/7577  
🟩 std
  🟩 17                 Pass: 100%/22  | Total:  3h 57m | Avg: 10m 48s | Max: 34m 30s | Hits:  95%/77066 
  🟩 20                 Pass: 100%/25  | Total:  5h 02m | Avg: 12m 06s | Max: 30m 33s | Hits:  95%/89807

🟩 cudax: Pass: 100%/28 | Total: 2h 35m | Avg: 5m 33s | Max: 12m 07s | Hits: 99%/15906

🟩 cpu
  🟩 amd64              Pass: 100%/24  | Total:  2h 23m | Avg:  5m 58s | Max: 12m 07s | Hits:  98%/13462 
  🟩 arm64              Pass: 100%/4   | Total: 12m 04s | Avg:  3m 01s | Max:  3m 21s | Hits:  99%/2444  
🟩 ctk
  🟩 12.0               Pass: 100%/3   | Total: 20m 14s | Avg:  6m 44s | Max: 12m 02s | Hits:  95%/1531  
  🟩 12.9               Pass: 100%/25  | Total:  2h 15m | Avg:  5m 24s | Max: 12m 07s | Hits:  99%/14375 
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/3   | Total: 20m 14s | Avg:  6m 44s | Max: 12m 02s | Hits:  95%/1531  
  🟩 nvcc12.9           Pass: 100%/25  | Total:  2h 15m | Avg:  5m 24s | Max: 12m 07s | Hits:  99%/14375 
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/28  | Total:  2h 35m | Avg:  5m 33s | Max: 12m 07s | Hits:  99%/15906 
🟩 cxx
  🟩 Clang14            Pass: 100%/2   | Total:  6m 09s | Avg:  3m 04s | Max:  3m 15s | Hits: 100%/1224  
  🟩 Clang15            Pass: 100%/1   | Total:  3m 29s | Avg:  3m 29s | Max:  3m 29s | Hits: 100%/611   
  🟩 Clang16            Pass: 100%/1   | Total:  3m 30s | Avg:  3m 30s | Max:  3m 30s | Hits: 100%/611   
  🟩 Clang17            Pass: 100%/1   | Total:  3m 27s | Avg:  3m 27s | Max:  3m 27s | Hits: 100%/611   
  🟩 Clang18            Pass: 100%/1   | Total:  3m 11s | Avg:  3m 11s | Max:  3m 11s | Hits: 100%/611   
  🟩 Clang19            Pass: 100%/4   | Total: 16m 39s | Avg:  4m 09s | Max:  7m 49s | Hits: 100%/2444  
  🟩 GCC10              Pass: 100%/2   | Total:  9m 12s | Avg:  4m 36s | Max:  5m 18s | Hits:  95%/1224  
  🟩 GCC11              Pass: 100%/1   | Total:  3m 38s | Avg:  3m 38s | Max:  3m 38s | Hits:  99%/611   
  🟩 GCC12              Pass: 100%/1   | Total:  3m 50s | Avg:  3m 50s | Max:  3m 50s | Hits:  99%/611   
  🟩 GCC13              Pass: 100%/8   | Total: 39m 51s | Avg:  4m 58s | Max: 11m 29s | Hits:  99%/4888  
  🟩 MSVC14.39          Pass: 100%/1   | Total: 12m 02s | Avg: 12m 02s | Max: 12m 02s | Hits:  95%/309   
  🟩 MSVC14.43          Pass: 100%/3   | Total: 34m 42s | Avg: 11m 34s | Max: 12m 07s | Hits:  95%/933   
  🟩 NVHPC25.5          Pass: 100%/2   | Total: 15m 48s | Avg:  7m 54s | Max:  7m 56s | Hits:  97%/1218  
🟩 cxx_family
  🟩 Clang              Pass: 100%/10  | Total: 36m 25s | Avg:  3m 38s | Max:  7m 49s | Hits: 100%/6112  
  🟩 GCC                Pass: 100%/12  | Total: 56m 31s | Avg:  4m 42s | Max: 11m 29s | Hits:  98%/7334  
  🟩 MSVC               Pass: 100%/4   | Total: 46m 44s | Avg: 11m 41s | Max: 12m 07s | Hits:  95%/1242  
  🟩 NVHPC              Pass: 100%/2   | Total: 15m 48s | Avg:  7m 54s | Max:  7m 56s | Hits:  97%/1218  
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 10m 17s | Avg:  5m 08s | Max:  7m 10s | Hits:  99%/1222  
  🟩 rtx2080            Pass: 100%/26  | Total:  2h 25m | Avg:  5m 35s | Max: 12m 07s | Hits:  98%/14684 
🟩 jobs
  🟩 Build              Pass: 100%/25  | Total:  2h 09m | Avg:  5m 09s | Max: 12m 07s | Hits:  98%/14073 
  🟩 Test               Pass: 100%/3   | Total: 26m 28s | Avg:  8m 49s | Max: 11m 29s | Hits:  99%/1833  
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 10m 17s | Avg:  5m 08s | Max:  7m 10s | Hits:  99%/1222  
  🟩 90;90a             Pass: 100%/2   | Total: 15m 58s | Avg:  7m 59s | Max: 12m 07s | Hits:  98%/922   
  🟩 100;120            Pass: 100%/2   | Total: 14m 49s | Avg:  7m 24s | Max: 11m 06s | Hits:  98%/922   
🟩 std
  🟩 17                 Pass: 100%/3   | Total: 13m 58s | Avg:  4m 39s | Max:  7m 56s | Hits:  99%/1831  
  🟩 20                 Pass: 100%/25  | Total:  2h 21m | Avg:  5m 39s | Max: 12m 07s | Hits:  98%/14075

🟩 python: Pass: 100%/22 | Total: 3h 46m | Avg: 10m 18s | Max: 22m 36s

🟩 cpu
  🟩 amd64              Pass: 100%/22  | Total:  3h 46m | Avg: 10m 18s | Max: 22m 36s
🟩 ctk
  🟩 12.5               Pass: 100%/6   | Total: 42m 40s | Avg:  7m 06s | Max: 13m 37s
  🟩 12.8               Pass: 100%/2   | Total: 37m 04s | Avg: 18m 32s | Max: 18m 34s
  🟩 12.9               Pass: 100%/14  | Total:  2h 26m | Avg: 10m 29s | Max: 22m 36s
🟩 cudacxx
  🟩 nvcc12.5           Pass: 100%/6   | Total: 42m 40s | Avg:  7m 06s | Max: 13m 37s
  🟩 nvcc12.8           Pass: 100%/2   | Total: 37m 04s | Avg: 18m 32s | Max: 18m 34s
  🟩 nvcc12.9           Pass: 100%/14  | Total:  2h 26m | Avg: 10m 29s | Max: 22m 36s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/22  | Total:  3h 46m | Avg: 10m 18s | Max: 22m 36s
🟩 cxx
  🟩 GCC13              Pass: 100%/22  | Total:  3h 46m | Avg: 10m 18s | Max: 22m 36s
🟩 cxx_family
  🟩 GCC                Pass: 100%/22  | Total:  3h 46m | Avg: 10m 18s | Max: 22m 36s
🟩 gpu
  🟩 h100               Pass: 100%/4   | Total: 46m 10s | Avg: 11m 32s | Max: 22m 36s
  🟩 l4                 Pass: 100%/18  | Total:  3h 00m | Avg: 10m 01s | Max: 19m 22s
🟩 jobs
  🟩 Build cuda.cccl    Pass: 100%/2   | Total: 19m 31s | Avg:  9m 45s | Max:  9m 58s
  🟩 Test cuda.cccl.cooperative Pass: 100%/5   | Total:  1h 08m | Avg: 13m 44s | Max: 15m 26s
  🟩 Test cuda.cccl.examples Pass: 100%/5   | Total: 21m 32s | Avg:  4m 18s | Max:  4m 38s
  🟩 Test cuda.cccl.headers Pass: 100%/5   | Total: 19m 16s | Avg:  3m 51s | Max:  4m 09s
  🟩 Test cuda.cccl.parallel Pass: 100%/5   | Total:  1h 37m | Avg: 19m 31s | Max: 22m 36s
🟩 py_version
  🟩 3.10               Pass: 100%/9   | Total:  1h 30m | Avg: 10m 03s | Max: 18m 36s
  🟩 3.13               Pass: 100%/13  | Total:  2h 16m | Avg: 10m 28s | Max: 22m 36s

🟩 packaging: Pass: 100%/4 | Total: 12m 37s | Avg: 3m 09s | Max: 4m 00s

🟩 cpu
  🟩 amd64              Pass: 100%/4   | Total: 12m 37s | Avg:  3m 09s | Max:  4m 00s
🟩 ctk
  🟩 12.0               Pass: 100%/2   | Total:  5m 35s | Avg:  2m 47s | Max:  2m 56s
  🟩 12.9               Pass: 100%/2   | Total:  7m 02s | Avg:  3m 31s | Max:  4m 00s
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/2   | Total:  5m 35s | Avg:  2m 47s | Max:  2m 56s
  🟩 nvcc12.9           Pass: 100%/2   | Total:  7m 02s | Avg:  3m 31s | Max:  4m 00s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/4   | Total: 12m 37s | Avg:  3m 09s | Max:  4m 00s
🟩 cxx
  🟩 Clang14            Pass: 100%/1   | Total:  2m 39s | Avg:  2m 39s | Max:  2m 39s
  🟩 Clang19            Pass: 100%/1   | Total:  3m 02s | Avg:  3m 02s | Max:  3m 02s
  🟩 GCC12              Pass: 100%/1   | Total:  2m 56s | Avg:  2m 56s | Max:  2m 56s
  🟩 GCC13              Pass: 100%/1   | Total:  4m 00s | Avg:  4m 00s | Max:  4m 00s
🟩 cxx_family
  🟩 Clang              Pass: 100%/2   | Total:  5m 41s | Avg:  2m 50s | Max:  3m 02s
  🟩 GCC                Pass: 100%/2   | Total:  6m 56s | Avg:  3m 28s | Max:  4m 00s
🟩 gpu
  🟩 rtx2080            Pass: 100%/4   | Total: 12m 37s | Avg:  3m 09s | Max:  4m 00s
🟩 jobs
  🟩 Test               Pass: 100%/4   | Total: 12m 37s | Avg:  3m 09s | Max:  4m 00s

🟩 stdpar: Pass: 100%/4 | Total: 16m 11s | Avg: 4m 02s | Max: 4m 22s

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  8m 14s | Avg:  4m 07s | Max:  4m 22s
  🟩 arm64              Pass: 100%/2   | Total:  7m 57s | Avg:  3m 58s | Max:  4m 08s
🟩 ctk
  🟩 12.9               Pass: 100%/4   | Total: 16m 11s | Avg:  4m 02s | Max:  4m 22s
🟩 cudacxx
  🟩 nvcc12.9           Pass: 100%/4   | Total: 16m 11s | Avg:  4m 02s | Max:  4m 22s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/4   | Total: 16m 11s | Avg:  4m 02s | Max:  4m 22s
🟩 cxx
  🟩 NVHPC25.5          Pass: 100%/4   | Total: 16m 11s | Avg:  4m 02s | Max:  4m 22s
🟩 cxx_family
  🟩 NVHPC              Pass: 100%/4   | Total: 16m 11s | Avg:  4m 02s | Max:  4m 22s
🟩 gpu
  🟩 rtx2080            Pass: 100%/4   | Total: 16m 11s | Avg:  4m 02s | Max:  4m 22s
🟩 jobs
  🟩 Build              Pass: 100%/4   | Total: 16m 11s | Avg:  4m 02s | Max:  4m 22s
🟩 std
  🟩 17                 Pass: 100%/2   | Total:  8m 00s | Avg:  4m 00s | Max:  4m 08s
  🟩 20                 Pass: 100%/2   | Total:  8m 11s | Avg:  4m 05s | Max:  4m 22s

🟩 cccl_c_parallel: Pass: 100%/3 | Total: 26m 34s | Avg: 8m 51s | Max: 13m 57s | Hits: 98%/495

🟩 cpu
  🟩 amd64              Pass: 100%/3   | Total: 26m 34s | Avg:  8m 51s | Max: 13m 57s | Hits:  98%/495   
🟩 ctk
  🟩 12.9               Pass: 100%/3   | Total: 26m 34s | Avg:  8m 51s | Max: 13m 57s | Hits:  98%/495   
🟩 cudacxx
  🟩 nvcc12.9           Pass: 100%/3   | Total: 26m 34s | Avg:  8m 51s | Max: 13m 57s | Hits:  98%/495   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/3   | Total: 26m 34s | Avg:  8m 51s | Max: 13m 57s | Hits:  98%/495   
🟩 cxx
  🟩 GCC13              Pass: 100%/3   | Total: 26m 34s | Avg:  8m 51s | Max: 13m 57s | Hits:  98%/495   
🟩 cxx_family
  🟩 GCC                Pass: 100%/3   | Total: 26m 34s | Avg:  8m 51s | Max: 13m 57s | Hits:  98%/495   
🟩 gpu
  🟩 h100               Pass: 100%/1   | Total: 13m 57s | Avg: 13m 57s | Max: 13m 57s | Hits:  98%/165   
  🟩 rtx2080            Pass: 100%/2   | Total: 12m 37s | Avg:  6m 18s | Max: 10m 38s | Hits:  98%/330   
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  1m 59s | Avg:  1m 59s | Max:  1m 59s | Hits:  98%/165   
  🟩 Test               Pass: 100%/2   | Total: 24m 35s | Avg: 12m 17s | Max: 13m 57s | Hits:  98%/330

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	CCCL Packaging
+/-	libcu++
	CUB
	Thrust
	CUDA Experimental
	stdpar
	python
	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
+/-	CCCL Packaging
+/-	libcu++
+/-	CUB
+/-	Thrust
+/-	CUDA Experimental
+/-	stdpar
+/-	python
+/-	CCCL C Parallel Library
+/-	Catch2Helper

🏃‍ Runner counts (total jobs: 209)

#	Runner
128	`linux-amd64-cpu16`
23	`windows-amd64-cpu16`
16	`linux-amd64-gpu-l4-latest-1`
12	`linux-arm64-cpu16`
11	`linux-amd64-gpu-rtx2080-latest-1`
10	`linux-amd64-gpu-h100-latest-1`
6	`linux-amd64-gpu-rtxa6000-latest-1`
3	`linux-amd64-gpu-rtx4090-latest-1`

bernhardmgruber · 2025-07-23T19:05:23Z

I know. It was in 3.1 actually, so I am not sure whether it's too late for the change

I think backporting to 3.1 is still fine, but let's also ask the grand integrator @wmaxey.

Regarding the order of arguments, I don't have a strong opinion.

fbusato · 2025-07-23T19:11:30Z

I'm in favor of the change proposed by @davebayer.

davebayer · 2025-07-23T19:19:29Z

And I've just found another problem in the docs:

template <typename T>     // < remove this
[[nodiscard]] __device__ inline
bool is_address_from(address_space space, const void* ptr)

Can you fix it, please?

fbusato · 2025-07-23T19:57:22Z

sure!

fbusato · 2025-07-23T20:00:57Z

actually, would be also nice to also have is_address_from(T&, address_space) with T != pointer.

cuda::device::is_address_from(global_var, address_space::global); // no &global_var

What do you think?

davebayer · 2025-07-23T20:21:11Z

actually, would be also nice to also have is_address_from(T&, address_space) with T != pointer.
cuda::device::is_address_from(global_var, address_space::global); // no &global_var
What do you think?

I don't think the function name describes this overload very well. I think it the user should just do &var or cuda::std::addressof(var) himself.

I would expect to have something like get_address_space_of(var) which would return address_space of the variable, but it makes no sense from the generated PTX perspective, unless the optimizer steps in and can correctly optimize this out.

davebayer · 2025-07-23T20:46:54Z

I would expect to have something like get_address_space_of(var) which would return address_space of the variable, but it makes no sense from the generated PTX perspective, unless the optimizer steps in and can correctly optimize this out.

Actually that makes no sense, because the spaces can overlap. Okay, so what about is_object_from?

github-actions · 2025-07-24T10:37:45Z

Backport failed for branch/3.1.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin branch/3.1.x
git worktree add -d .worktree/backport-5349-to-branch/3.1.x origin/branch/3.1.x
cd .worktree/backport-5349-to-branch/3.1.x
git switch --create backport-5349-to-branch/3.1.x
git cherry-pick -x 5dbfd89ccc2e5d6b7f95889b5daa792225d5b26f

fbusato · 2025-07-24T15:50:58Z

is_object_from looks good. I have to open two PRs: one for the backport and the other for the new function + doc fix

forgot to add inline in is_address_from

5118e2a

fbusato self-assigned this Jul 23, 2025

fbusato requested a review from a team as a code owner July 23, 2025 17:53

fbusato requested a review from wmaxey July 23, 2025 17:53

fbusato added the 3.2.0 Targeted for 3.2.0 release label Jul 23, 2025

fbusato added this to CCCL Jul 23, 2025

github-project-automation bot moved this to Todo in CCCL Jul 23, 2025

fbusato moved this from Todo to In Review in CCCL Jul 23, 2025

fbusato enabled auto-merge (squash) July 23, 2025 17:53

fbusato disabled auto-merge July 23, 2025 18:23

bernhardmgruber approved these changes Jul 23, 2025

View reviewed changes

wmaxey approved these changes Jul 24, 2025

View reviewed changes

wmaxey added backport done This PR has been backported to the relevant branch backport branch/3.1.x and removed backport done This PR has been backported to the relevant branch labels Jul 24, 2025

bernhardmgruber merged commit 5dbfd89 into NVIDIA:main Jul 24, 2025
222 checks passed

github-project-automation bot moved this from In Review to Done in CCCL Jul 24, 2025

This was referenced Jul 24, 2025

[Backport 3.1.x] is_address_from fixes (#5349) #5363

Open

Add is_object_from #5364

Open

Forgot to add inline in is_address_from #5349

Forgot to add inline in is_address_from #5349

Uh oh!

Conversation

fbusato commented Jul 23, 2025

Uh oh!

davebayer commented Jul 23, 2025

Uh oh!

fbusato commented Jul 23, 2025

Uh oh!

davebayer commented Jul 23, 2025

Uh oh!

github-actions bot commented Jul 23, 2025

🟩 cub: Pass: 100%/50 | Total: 11h 04m | Avg: 13m 16s | Max: 34m 27s | Hits: 99%/51848

🟩 thrust: Pass: 100%/50 | Total: 8h 52m | Avg: 10m 39s | Max: 32m 50s | Hits: 99%/84139

🟩 libcudacxx: Pass: 100%/48 | Total: 9h 02m | Avg: 11m 17s | Max: 34m 30s | Hits: 95%/166873

🟩 cudax: Pass: 100%/28 | Total: 2h 35m | Avg: 5m 33s | Max: 12m 07s | Hits: 99%/15906

🟩 python: Pass: 100%/22 | Total: 3h 46m | Avg: 10m 18s | Max: 22m 36s

🟩 packaging: Pass: 100%/4 | Total: 12m 37s | Avg: 3m 09s | Max: 4m 00s

🟩 stdpar: Pass: 100%/4 | Total: 16m 11s | Avg: 4m 02s | Max: 4m 22s

🟩 cccl_c_parallel: Pass: 100%/3 | Total: 26m 34s | Avg: 8m 51s | Max: 13m 57s | Hits: 98%/495

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 209)

Uh oh!

bernhardmgruber commented Jul 23, 2025

Uh oh!

fbusato commented Jul 23, 2025

Uh oh!

davebayer commented Jul 23, 2025

Uh oh!

fbusato commented Jul 23, 2025

Uh oh!

fbusato commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davebayer commented Jul 23, 2025

Uh oh!

davebayer commented Jul 23, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 24, 2025

Uh oh!

fbusato commented Jul 24, 2025

Uh oh!

Uh oh!

Forgot to add `inline` in `is_address_from` #5349

Forgot to add `inline` in `is_address_from` #5349

fbusato commented Jul 23, 2025 •

edited

Loading