这是indexloc提供的服务,不要输入任何密码
Skip to content

Fix qwen2.5 1.5b configuration inheritance bug #12852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

Aprilistic
Copy link
Contributor

What does this PR do ?

Fix qwen2.5 1.5B configuration inheritance bug

Fix issue #12849

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Signed-off-by: Jinho Heo <uj07077@gmail.com>
Copy link
Collaborator

@suiyoubi suiyoubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks for fixing this. LGTM

@suiyoubi suiyoubi enabled auto-merge (squash) April 2, 2025 13:23
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Apr 2, 2025
@suiyoubi suiyoubi merged commit 2cf23a7 into NVIDIA:main Apr 3, 2025
234 checks passed
rrbale-nvidia pushed a commit to rrbale-nvidia/NeMo that referenced this pull request Apr 11, 2025
Signed-off-by: Jinho Heo <uj07077@gmail.com>
Signed-off-by: Ritvik Bale <rbale@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants