Cherry pick Fix bugs in retriever sdg notebook (522) into r0.7.0
#560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * fixed qa bug 5008113, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * bug fixes for generator, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed precommit, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed filters, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed all issues, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed bug with document id, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * check if filtering pipeline is present, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed notebook, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * added functionality to filter pre-generated datasets, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * separated generation & filtering pipelines, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed pre-commit, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * minor changes, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed Ryan Wolf's comments, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * fixed minor bugs in configs, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * removed commented code in main.py, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * added CLI flags for generation & filtering removed code duplication, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * minor fix to quickstart notebook, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * removed filter.py & generate.py, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> --------- Signed-off-by: viraman <viraman@nvidia.com> Signed-off-by: Vinay Raman <viraman@nvidia.com>
8dba0c1 to
91e39bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beep boop [🤖]: Hi @vinay-raman 👋,