这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: allow passing extra args to cli #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: allow passing extra args to cli #219

wants to merge 3 commits into from
+2 −2

Conversation

akoumpa
Copy link
Contributor

@akoumpa akoumpa commented Jul 18, 2025

Allow extra args that are used to overwrite settings in the YAML config, for example,

automodel finetune llm -c examples/llm/llama_3_2_1b_squad.yaml --distributed.backend gloo --model.attn_implementation eager

Would overwrite:

distributed:
   backedn: gloo

model:
   attn_implementation: eager

@akoumpa
allow passing extra args to cli
4a409db 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 18, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@akoumpa
Copy link
Contributor Author

akoumpa commented Jul 19, 2025

/ok to test 4a409db

@akoumpa
Copy link
Contributor Author

akoumpa commented Jul 20, 2025

/ok to test 4a409db

@akoumpa
Copy link
Contributor Author

akoumpa commented Jul 20, 2025

/ok to test aa09ece

@akoumpa
Copy link
Contributor Author

akoumpa commented Jul 20, 2025

/ok to test bf05dbf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoxiangW BoxiangW Awaiting requested review from BoxiangW BoxiangW will be requested when the pull request is marked ready for review BoxiangW is a code owner

@HuiyingLi HuiyingLi Awaiting requested review from HuiyingLi HuiyingLi will be requested when the pull request is marked ready for review HuiyingLi is a code owner

@adil-a adil-a Awaiting requested review from adil-a adil-a will be requested when the pull request is marked ready for review adil-a is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akoumpa