Undo redo manager batch 1 #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes potential issue where mSelectionRect would be expanded, even if YesOrNo is false.
This is done automatically in the QObject destructor. Calling it here could potentially mess up code it we ever use the destroyed() signal for this object.
Mostly this was just refactoring to remove the redundant code between functions, but it also makes minor functional changes which will hopefully not affect anything: - Empty sound frames are now overridden - The current layer is not changed if adding the new keyframe was unsuccessful - currentLayerChanged(), frameModified(), and animationLengthChanged() will now be emitted
More refactoring, with the following functional changes: - deselectAll is called before removing frame with removeKeyAtLayerId - currentLayerChanged(), frameModified(), and animationLengthChanged() is emitted even if the layer isn't changed with removeKeyAtId - Case where no layer with id layerId is caught
MrStevns
reviewed
Jul 7, 2021
Comment on lines
+1088
to
+1091
| if (shouldBackup) | ||
| { | ||
| backup(tr("Remove frame")); | ||
| } |
Owner
There was a problem hiding this comment.
Why would you want to remove a key and not do a state change? we won't be able to go back otherwise.
Author
There was a problem hiding this comment.
removeKeyAtLayerId wasn't backing it up before these changes. You want to remove a key and not do a state change when you're calling that from backupelements so you don't get into some infinite backup loop. Key removals triggered by an action use removeKey() which still does a back.
Owner
There was a problem hiding this comment.
Agh.. you're right, I forgot about that one. I couldn't remember it well enough and the diff didn't make it obvious.
MrStevns
approved these changes
Jul 7, 2021
Owner
MrStevns
left a comment
There was a problem hiding this comment.
I have one comment but otherwise the changes looks good.
👍
I will merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the suggested changes I have so far for the undo-redo-manager branch. This should just about cover all the issues I've found outside of backupmanager.h/.cpp and backupelement.h/.cpp. Review of those files is ongoing and will require some back-and-forth.