Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (3705cea) to head (1f02517).
Report is 61 commits behind head on main.

@@          Coverage Diff           @@
##            main    #935    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files         33      34     +1     
  Lines       5640    5801   +161     
======================================
- Misses      5640    5801   +161     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is not what the verbose option is used for, it's specifically for adding low-level debugging information to the log. The progress bar is necessary for the GUI animation. Are you just wanting an option to skip printing the progress bar updates in the log when running through API?

This is not what the verbose option is used for, it's specifically for adding low-level debugging information to the log. The progress bar is necessary for the GUI animation.

Thanks @jacobpennington, I misinterpreted it then!

Are you just wanting an option to skip printing the progress bar updates in the log when running through API?

Exactly what I'm looking for

Okay, thanks. This was on the todo list at some point, I'll take another look. I'd rather not add yet another option to manually disable something that shouldn't happen in the first place, if possible. I.e. the progress bar should never appear in the logs, I just hadn't figured out how to prevent that without disabling it altogether.

I think that something like this might work:

show_progress = logger.isEnabledFor(logging.INFO)

tqdm(..., disable=not show_progress)

I'll give it a shot!

I guess I misremembered this issue... Looking at the logs generated now, I don't see any of the tqdm progress bar information there when running Kilosort4 on its own. I do remember seeing user-posted logs that included progress bar spam, but now that I look back all of those were people who used KS4 through spikeinterface. There was also an issue for a while with a log not being generated when using spikeinterface, although it seems that was fixed at some point. Regardless, SI seems to be interfering with the logging behavior somehow.

Can you please confirm which conditions result in the log spam? I.e. running with API or GUI, with or without spikeinterface.

I guess I misremembered this issue... Looking at the logs generated now, I don't see any of the tqdm progress bar information there when running Kilosort4 on its own. I do remember seeing user-posted logs that included progress bar spam, but now that I look back all of those were people who used KS4 through spikeinterface. There was also an issue for a while with a log not being generated when using spikeinterface, although it seems that was fixed at some point. Regardless, SI seems to be interfering with the logging behavior somehow.

Can you please confirm which conditions result in the log spam? I.e. running with API or GUI, with or without spikeinterface.

Hi Jakob, this is runnning through the API. Here is the recent PR interacting with the KS4 logger. SpikeInterface/spikeinterface#3866

I still haven't been able to reproduce this. Unless someone can provide an example of this without using Spikeinterface, I don't see anything to change on the Kilosort end.