θΏ™ζ˜―indexlocζδΎ›ηš„ζœεŠ‘οΌŒδΈθ¦θΎ“ε…₯任何密码
Skip to content

Conversation

@timothycarambat
Copy link
Member

@timothycarambat timothycarambat commented Feb 14, 2024

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

What is in this change?

The Chat backend for chat/stream/embed was getting messy and have multiple execution paths, now they are normalized across all interfaces for easier readability and maintainability.

Additional Information

This PR needs to be heavily QA'd

  • stream chat empty workspace
  • stream chat empty history recall test
  • query chat empty
  • query chat with embedding test
  • query chat ensure no history recall
  • Do all of the above on default and threaded
  • Embed chat
  • Embed query
  • Async chat response test for empty workpsace
  • Aysnc chat response test empty history recall
  • Async query empty
  • Async query embedding
  • API chat
  • API stream

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

…so that it is easier to maintain and build upon
@Mintplex-Labs Mintplex-Labs deleted a comment from review-agent-prime bot Feb 14, 2024
@timothycarambat
Copy link
Member Author

Good to merge

@timothycarambat timothycarambat merged commit c59ab9d into master Feb 14, 2024
@timothycarambat timothycarambat deleted the chat-backend-refactor branch February 14, 2024 20:32
cabwds pushed a commit to cabwds/anything-llm that referenced this pull request Jul 3, 2025
* refactor stream/chat/embed-stram to be a single execution logic path so that it is easier to maintain and build upon

* no thread in sync chat since only api uses it
adjust import locations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants