improve error messages from YT scraping #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse & enforce URL to allow multiple URL schemas
collector/utils/extensions/YoutubeTranscript/index.jsInstead of returning the raw error message to the user, it would be better to log the error and return a generic error message. This will prevent potential information leakage. const { docs, error } = await loader
.load()
.then((docs) => {
return { docs, error: null };
})
.catch((e) => {
console.error(e);
return {
docs: [],
error: "An error occurred while loading the transcript.",
};
}); |
cabwds
pushed a commit
to cabwds/anything-llm
that referenced
this pull request
Jul 3, 2025
parse & enforce URL to allow multiple URL schemas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #766
What is in this change?
Describe the changes in this PR that are impactful to the repo.
Additional Information
improve error messages from YT scraping when transcriptions are disabled
allow all youtube URLS and then parse the given URL and see if we can enforce it then instead of blocking all URLs that dont match the schema on input.
Developer Validations
yarn lintfrom the root of the repo & committed changes