这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@shatfield4
Copy link
Collaborator

@shatfield4 shatfield4 commented Feb 6, 2024

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #682

What is in this change?

Describe the changes in this PR that are impactful to the repo.

  • When the instance is in multiusermode, we hide the security settings tab because there is no point in showing this screen since you cannot modify anything after multiusermode is enabled.
  • Refactor SettingsSidebar component so that we do not have a separate mobile sidebar anymore and render the same options on both.

Additional Information

Add any other context about the Pull Request here that was not captured above.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@shatfield4 shatfield4 linked an issue Feb 6, 2024 that may be closed by this pull request
Copy link
Member

@timothycarambat timothycarambat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to update the mobile sidebar as well. This seems to occur each time we update the setting sidebar. Lets refactor this component to where the Mobile and Desktop layout are rendering the same options, but they keep their specific container styles.

@shatfield4 shatfield4 changed the title [FEAT] Hide security tab on Settings Sidebar [FEAT] Hide security tab on Settings Sidebar/Refactor SettingsSidebar component Feb 7, 2024
move footer on settingSidebar to component
@timothycarambat timothycarambat changed the title [FEAT] Hide security tab on Settings Sidebar/Refactor SettingsSidebar component [CHORE] Hide security tab on Settings Sidebar/Refactor SettingsSidebar component Feb 7, 2024
@Mintplex-Labs Mintplex-Labs deleted a comment from review-agent-prime bot Feb 7, 2024
@timothycarambat timothycarambat merged commit f402ef4 into master Feb 7, 2024
@timothycarambat timothycarambat deleted the 682-feat-hide-security-tab-on-setting-sidbar branch February 7, 2024 16:17
cabwds pushed a commit to cabwds/anything-llm that referenced this pull request Jul 3, 2025
…r component (Mintplex-Labs#683)

* hide security setting in settings sidebar when in multiusermode

* refactor sidebar to handle mobile view inside SettingsSidebar component

* forgot eventlogs on sidebar
move footer on settingSidebar to component

---------

Co-authored-by: timothycarambat <rambat1010@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Hide Security Tab on Setting Sidbar

3 participants