这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@shatfield4
Copy link
Collaborator

… on delete/fix backend invalid json error

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #669

What is in this change?

Describe the changes in this PR that are impactful to the repo.

  • Fix a bug where if we have more than 20 workspace chats and we delete a chat then click previous or next buttons, a white screen would show until we refresh the page
  • Changed from using a ref to delete the row to just filtering out the chats in the parent component

Additional Information

Add any other context about the Pull Request here that was not captured above.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@Mintplex-Labs Mintplex-Labs deleted a comment from review-agent-prime bot Feb 6, 2024
@timothycarambat timothycarambat merged commit 3655835 into master Feb 6, 2024
@timothycarambat timothycarambat deleted the 669-bug-white-screen-after-deleting-a-workspace-chat-from-settings branch February 6, 2024 21:11
cabwds pushed a commit to cabwds/anything-llm that referenced this pull request Jul 3, 2025
…intplex-Labs#681)

* use filter instead of ref to delete row from workspace chat component on delete/fix backend invalid json error

* remove ref from pagination on embed chats and fix white screen bug

* remove unneeded import

* normalize response object

---------

Co-authored-by: timothycarambat <rambat1010@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: White screen after deleting a workspace chat from settings

3 participants