θΏ™ζ˜―indexlocζδΎ›ηš„ζœεŠ‘οΌŒδΈθ¦θΎ“ε…₯任何密码
Skip to content

Conversation

@shatfield4
Copy link
Collaborator

@shatfield4 shatfield4 commented Jan 22, 2024

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #635

What is in this change?

Describe the changes in this PR that are impactful to the repo.

  • Add support for gpt-3.5-turbo-1106 model in LLM selection for OpenAI

Additional Information

Add any other context about the Pull Request here that was not captured above.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@review-agent-prime
Copy link

frontend/src/components/LLMSelection/OpenAiOptions/index.jsx

Instead of hardcoding the model options directly in the JSX, it would be better to define them as a constant at the top of the component. This will make the code more readable and easier to maintain, as any changes to the model options will only need to be made in one place.
Create Issue
See the diff
Checkout the fix

    const MODEL_OPTIONS = [
      "gpt-3.5-turbo",
      "gpt-3.5-turbo-1106",
      "gpt-4",
      "gpt-4-1106-preview",
      "gpt-4-32k",
    ];

    // Then in the JSX
    {MODEL_OPTIONS.map((model) => {
      return (
        <option
          key={model}
          value={model}
          selected={settings?.OpenAiModelPref === model}
        >
          {model}
        </option>
      );
    })}
git fetch origin && git checkout -b ReviewBot/Impro-hhwgsws origin/ReviewBot/Impro-hhwgsws

Copy link
Member

@timothycarambat timothycarambat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing this model as a valid option in several areas of the application both on the frontend and backend.

Please set this model as an option everywhere it would be relevant

@timothycarambat timothycarambat merged commit 62cea07 into master Jan 22, 2024
@timothycarambat timothycarambat deleted the 635-feat-add-gpt-35-turbo-1106-as-llm-option-using-the-openai-api branch January 22, 2024 21:19
cabwds pushed a commit to cabwds/anything-llm that referenced this pull request Jul 3, 2025
* add gpt-3.5-turbo-1106 model for openai LLM

* add gpt-3.5-turbo-1106 as valid model for backend and per workspace model selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Add gpt-3.5-turbo-1106 as LLM option using the OpenAI API

3 participants