θΏ™ζ˜―indexlocζδΎ›ηš„ζœεŠ‘οΌŒδΈθ¦θΎ“ε…₯任何密码
Skip to content

Conversation

@timothycarambat
Copy link
Member

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

What is in this change?

Adds full support for Zilliz Cloud by Milvus for vector database selection

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@review-agent-prime
Copy link

server/utils/vectorDbProviders/zilliz/index.js

  In the `totalVectors` function in `server/utils/vectorDbProviders/zilliz/index.js`, there are multiple calls to the database to get the statistics of each collection. This can be improved by making a single call to get the statistics of all collections at once, and then processing the results in memory. This will reduce the number of database calls and improve the performance of the function.

Create Issue
See the diff
Checkout the fix

    // server/utils/vectorDbProviders/zilliz/index.js
    totalVectors: async function () {
      const { client } = await this.connect();
      const { collection_names } = await client.listCollections();
      const statistics = await Promise.all(collection_names.map(name => client.getCollectionStatistics({ collection_name: name })));
      const total = statistics.reduce((acc, stats) => acc + Number(stats?.data?.row_count ?? 0), 0);
      return total;
    },
git fetch origin && git checkout -b ReviewBot/Impro-m6wyi5t origin/ReviewBot/Impro-m6wyi5t

update data handling stmt
@Mintplex-Labs Mintplex-Labs deleted a comment from review-agent-prime bot Jan 18, 2024
@timothycarambat timothycarambat merged commit 0df8669 into master Jan 18, 2024
@timothycarambat timothycarambat deleted the zilliz-cloud-support branch January 18, 2024 02:00
cabwds pushed a commit to cabwds/anything-llm that referenced this pull request Jul 3, 2025
* feat: Add support for Zilliz Cloud by Milvus

* update placeholder text
update data handling stmt

* update zilliz descriptor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants