Update Ubuntu base image and improve Dockerfile #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robustness Upgraded the base Ubuntu image to the latest version to incorporate current security and package updates. Enhanced Dockerfile by introducing pipefail shell option to ensure any step in a pipe sequence failing will fail the entire pipeline, increasing build reliability. Refactored user creation commands for clarity and consistency and removed unnecessary unzip and git installations. Simplified RUN instructions in the Dockerfile to facilitate maintenance and potential readability. Adjusted the execution permission setting of entrypoint and healthcheck scripts to be more concise. Normalized quoting and whitespace within RUN commands and shell scripts for consistency across the codebase. Ensured proper ownership of copied files at build time to prevent potential permission issues during container startup. Shifted to WORKDIR instructions for setting the working directory instead of using 'cd' for better readability and Docker best practices. Resolved missing newline characters at the end of shell scripts which follows common conventions and aids in file concatenation. These changes contribute to the stabilization and optimization of the Docker build process, which should result in more consistent and reliable builds for the AnythingLLM project.
Needed for the arm64 build
timothycarambat
approved these changes
Jan 27, 2024
Contributor
Author
|
In review, I realized that this was closed and not merged... |
…being handled by MS Docker extension which doesn't indent code as expected. WIP.
Contributor
Author
|
now it is 100% :) |
Contributor
Author
|
The only conflict shown here is not a conflict, but a fix... may have appeared after the pull request was sent. |
cabwds
pushed a commit
to cabwds/anything-llm
that referenced
this pull request
Jul 3, 2025
* Update Ubuntu base image and improve Dockerfile * Add unzip to Docker image dependencies Needed for the arm64 build * reset tabs * formalized lint rules for hadolint. however the Docker formatting is being handled by MS Docker extension which doesn't indent code as expected. WIP. * found a workaround to keep formatting --------- Co-authored-by: timothycarambat <rambat1010@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
robustness
Upgraded the base Ubuntu image to the latest version to incorporate current security and package updates. Enhanced Dockerfile by introducing pipefail shell option to ensure any step in a pipe sequence failing will fail the entire pipeline, increasing build reliability. Refactored user creation commands for clarity and consistency and removed unnecessary unzip and git installations. Simplified RUN instructions in the Dockerfile to facilitate maintenance and potential readability. Adjusted the execution permission setting of entrypoint and healthcheck scripts to be more concise.
Normalized quoting and whitespace within RUN commands and shell scripts for consistency across the codebase. Ensured proper ownership of copied files at build time to prevent potential permission issues during container startup. Shifted to WORKDIR instructions for setting the working directory instead of using 'cd' for better readability and Docker best practices.
Resolved missing newline characters at the end of shell scripts which follows common conventions and aids in file concatenation.
These changes contribute to the stabilization and optimization of the Docker build process, which should result in more consistent and reliable builds for the AnythingLLM project.
Pull Request Type
Relevant Issues
What is in this change?
Describe the changes in this PR that are impactful to the repo.
Additional Information
Add any other context about the Pull Request here that was not captured above.
Developer Validations
yarn lintfrom the root of the repo & committed changes