Add support for fetching single document in documents folder #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/endpoints/api/document/index.jsCurrently, the error messages are directly logged to the console and a generic 500 status code is sent to the client. This could potentially leak sensitive information to the client. It would be better to send a generic error message to the client and log the error details on the server side for debugging purposes. try {
const { docName } = request.params;
const document = await findDocumentInDocuments(docName);
if (!document) {
response.sendStatus(404).end();
return;
}
response.status(200).json({ document });
} catch (e) {
console.error(e);
response.status(500).json({ error: 'An error occurred while processing your request.' }).end();
} |
Comment on lines
+180
to
+191
| try { | ||
| const { docName } = request.params; | ||
| const document = await findDocumentInDocuments(docName); | ||
| if (!document) { | ||
| response.sendStatus(404).end(); | ||
| return; | ||
| } | ||
| response.status(200).json({ document }); | ||
| } catch (e) { | ||
| console.log(e.message, e); | ||
| response.sendStatus(500).end(); | ||
| } |
There was a problem hiding this comment.
The error handling has been improved by sending a generic error message to the client and logging the error details on the server side for debugging purposes.
Suggested change
| try { | |
| const { docName } = request.params; | |
| const document = await findDocumentInDocuments(docName); | |
| if (!document) { | |
| response.sendStatus(404).end(); | |
| return; | |
| } | |
| response.status(200).json({ document }); | |
| } catch (e) { | |
| console.log(e.message, e); | |
| response.sendStatus(500).end(); | |
| } | |
| try { | |
| const { docName } = request.params; | |
| const document = await findDocumentInDocuments(docName); | |
| if (!document) { | |
| response.sendStatus(404).end(); | |
| return; | |
| } | |
| response.status(200).json({ document }); | |
| } catch (e) { | |
| console.error(e); | |
| response.status(500).json({ error: 'An error occurred while processing your request.' }).end(); | |
| } |
cabwds
pushed a commit
to cabwds/anything-llm
that referenced
this pull request
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #571
What is in this change?
Ability to fetch a single document in the
documentsfolder regardless of its subfolder. Will return on first match as each document name is unique.Additional Information
The document name is unique and should be a value found for
namein the/v1/documentsendpoint.Developer Validations
yarn lintfrom the root of the repo & committed changes