Preload onboarding #606
Merged
Preload onboarding #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend/src/App.jsxWhile the changes made in the code are correct, they could potentially lead to performance issues. Importing the OnboardingFlow component directly, as opposed to using dynamic imports (lazy loading), can lead to longer initial load times as the browser has to download more data initially. This can be especially problematic for users with slower internet connections. I suggest reverting back to using dynamic imports for the OnboardingFlow component. const OnboardingFlow = lazy(() => import("@/pages/OnboardingFlow")); |
cabwds
pushed a commit
to cabwds/anything-llm
that referenced
this pull request
Jul 3, 2025
* no lazy onboarding * no lazy onboarding steps * Do not lazy load onboarding to prevent lazy-load white flash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
What is in this change?
Prevents lazy loading of Onboarding pages as when onboarding the user will be subjected to brief white flashes on the page as the lazy component is loaded in. This is not a great UX for the user and will allow onboarding to be a better first-impression of the application.
Additional Information
This has very minimal impact on the bunded size of the application.
Developer Validations
yarn lintfrom the root of the repo & committed changes