Fix present diminsions on vectorDBs to be inferred for providers who require it #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/utils/vectorDbProviders/qdrant/index.jsInstead of using the submission.ids = vectors.map(vectorRecord => vectorRecord.id);
submission.vectors = vectors.map(vectorRecord => vectorRecord.vector);
submission.payloads = vectors.map(vectorRecord => vectorRecord.payload); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
What is in this change?
For vectorDbs who require a strict dimension argument on creation, we opt to now infer the dimensionality from the first chunk that is being upserted to the collection in question.
Additional Information
This only applies to Milvus and QDrant
Developer Validations
yarn lintfrom the root of the repo & committed changes