truncate title to shorter length so x button is not hidden for longer… #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… title names in the citation modal
frontend/src/components/WorkspaceChat/ChatContainer/ChatHistory/Citation/index.jsxThere is a repeated code block for rendering the SkeletonLine component. This can be extracted into a separate function to improve the readability of the code. const renderSkeletonLines = (count) => {
return [...Array(count)].map((_, idx) => (
<SkeletonLine key={idx} />
));
};
// Usage
{renderSkeletonLines(3)}The handleModalClose function is re-created every time the component re-renders. This can be avoided by using the useCallback hook. const handleModalClose = useCallback(() => {
if (dialogRef.current) {
dialogRef.current.close();
}
onClose();
}, [onClose]); |
timothycarambat
requested changes
Jan 16, 2024
frontend/src/components/WorkspaceChat/ChatContainer/ChatHistory/Citation/index.jsx
Outdated
Show resolved
Hide resolved
timothycarambat
approved these changes
Jan 16, 2024
cabwds
pushed a commit
to cabwds/anything-llm
that referenced
this pull request
Jul 3, 2025
Mintplex-Labs#603) * truncate title to shorter length so x button is not hidden for longer title names in the citation modal * absolutely position x button on citation modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #590
What is in this change?
Describe the changes in this PR that are impactful to the repo.
Additional Information
Add any other context about the Pull Request here that was not captured above.
Developer Validations
yarn lintfrom the root of the repo & committed changes