add check to skip empty messages #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/models/welcomeMessages.jsInstead of creating each message individually, you can use Prisma's bulk create method to create all messages at once. This will reduce the number of database calls and improve the performance of the function. const data = messages
.filter(message => message.response)
.map((message, index) => ({
user: message.user,
response: message.response,
orderIndex: index,
}));
await prisma.welcome_messages.createMany({ data });Instead of just logging the error, it would be better to throw the error to the caller function. This way, the caller function can decide how to handle the error (e.g., by sending an error response to the client). } catch (error) {
console.error("Failed to save all messages", error.message);
throw error;
} |
timothycarambat
requested changes
Jan 16, 2024
timothycarambat
approved these changes
Jan 17, 2024
10 tasks
cabwds
pushed a commit
to cabwds/anything-llm
that referenced
this pull request
Jul 3, 2025
* add check to skip empty messages * add comment explaining prisma + sqlite not supporting createMany()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #586
What is in this change?
Describe the changes in this PR that are impactful to the repo.
Additional Information
Add any other context about the Pull Request here that was not captured above.
Developer Validations
yarn lintfrom the root of the repo & committed changes