[FIX]: Fix Chinese characters causing empty workspace slug #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/models/workspace.jsInstead of using console.error to log the error message, it would be better to throw an error with a meaningful message. This will make it easier to debug and understand the error. Also, it would be better to use a try-catch block for each async operation separately. This will make it easier to identify which operation caused the error. try {
const workspace = await prisma.workspaces.create({
data: { name, slug },
});
} catch (error) {
throw new Error(`Failed to create workspace: ${error.message}`);
}
try {
if (!!creatorId) await WorkspaceUser.create(creatorId, workspace.id);
} catch (error) {
throw new Error(`Failed to create workspace user: ${error.message}`);
}It would be better to move the logic for generating a unique slug into a separate function. This will make the code more readable and maintainable. function generateUniqueSlug(name) {
var slug = slugify(name, { lower: true }) || uuidv4();
const existingBySlug = await this.get({ slug });
if (existingBySlug !== null) {
const slugSeed = Math.floor(10000000 + Math.random() * 90000000);
slug = slugify(`${name}-${slugSeed}`, { lower: true });
}
return slug;
} |
cabwds
pushed a commit
to cabwds/anything-llm
that referenced
this pull request
Jul 3, 2025
…Labs#660) if slug is empty on create workspace, generate a uuid as the workspace slug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e slug
Pull Request Type
Relevant Issues
resolves #659
What is in this change?
Describe the changes in this PR that are impactful to the repo.
Additional Information
Add any other context about the Pull Request here that was not captured above.
Developer Validations
yarn lintfrom the root of the repo & committed changes