Change pwd check to O(1) check to prevent timing attacks - single user mode #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AStevensTaylor
pushed a commit
to PacktDev/anything-llm
that referenced
this pull request
Jan 12, 2024
β¦r mode (Mintplex-Labs#575) Change pwd check to O(1) check to prevent timing attacks
cabwds
pushed a commit
to cabwds/anything-llm
that referenced
this pull request
Jul 3, 2025
β¦r mode (Mintplex-Labs#575) Change pwd check to O(1) check to prevent timing attacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
What is in this change?
For single-user mode, move
===tobcryptcomparison to prevent efficacy of timing attack potential. This is already covered for Multi-user.The risk of this is low as the overhead for the HTTP response varies from request to request making this opportunity near-impossible to execute, but why not patch it π
Developer Validations
yarn lintfrom the root of the repo & committed changes