[#572] Add Docker tags #573
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the DockerHub repository owner name
FEAT: Add doc return data
timothycarambat
requested changes
Jan 11, 2024
Member
timothycarambat
left a comment
There was a problem hiding this comment.
In this PR's current state it does not seem to reflect the origin master branch as it seems to include modifications to the API and document processor which would be out of scope for this PR.
Can you rebase with master so that only your GitHub action modifications are present?
Contributor
Author
|
Apologies, we are deploying our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #572
What is in this change?
Specifies tags to build for the docker build; allowing for a deployment to pin to a specific build of the repository.
It also allows for forks to be built onto GitHub's container repo.
Additional Information
The mintplex/anythingllm dockerhub tag is built if it is running on a fork with the
secrets.DOCKER_USERNAMEset, this could cause confusion for forks.Developer Validations
yarn lintfrom the root of the repo & committed changes