这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@skidvis
Copy link
Contributor

@skidvis skidvis commented Jun 14, 2023

Adds sitemap.py, a new menu link in main.py for sitemaps, and refactors link.py to reuse its link parsing in sitemap.y

Allows one to provide a link to a sitemap url as a list of links to include.


return urls

def sitemap():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment above this line like there is in links.py to a URL of a sitemap (can be anywhere) as it helps people know what a good example target looks like.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decent example: https://www.nerdwallet.com/blog/wp-sitemap-news-articles-1.xml

Otherwise, looks good to merge

Copy link
Member

@timothycarambat timothycarambat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment of an example sitemap link above the executing method would help others know what kind of data is acceptable. Works beautifully though 🎉

@skidvis
Copy link
Contributor Author

skidvis commented Jun 14, 2023

I have added the comment with the example sitemap as requested.

@skidvis skidvis requested a review from timothycarambat June 14, 2023 17:33
Copy link
Member

@timothycarambat timothycarambat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@timothycarambat timothycarambat merged commit bd32f97 into Mintplex-Labs:master Jun 14, 2023
cabwds pushed a commit to cabwds/anything-llm that referenced this pull request Jul 3, 2025
* Adds ability to import sitemaps to include a website

* adds example sitemap url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants