θΏ™ζ˜―indexlocζδΎ›ηš„ζœεŠ‘οΌŒδΈθ¦θΎ“ε…₯任何密码
Skip to content

Conversation

@yashschandra
Copy link
Contributor

@yashschandra yashschandra commented Feb 19, 2025

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #3268

What is in this change?

Stopped sending voice command directly as prompt to LLM provider so that user can get a chance to edit or add to it if there was a long pause while speaking.

Additional Information

Before -

before.mov

Now -

after.mov

Additionally fixed a minor typo: endTTSSession -> endSTTSession

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@timothycarambat
Copy link
Member

FWIW, it used to be this way, then people wanted it to autosubmit, now this PR would change it back

@therealtimex
Copy link

Can we implement two modes:

  • A long press of the microphone icon activates "continuous" mode, which enables autosubmit. The UI should visually indicate that this mode is active.
  • A short press of the microphone icon triggers manual submit.

@yashschandra
Copy link
Contributor Author

yashschandra commented Feb 19, 2025

FWIW, it used to be this way, then people wanted it to autosubmit, now this PR would change it back

I get this, but I feel for a non-native english speaking (like myself) it may be useful

Can we implement two modes:

A long press of the microphone icon activates "continuous" mode, which enables autosubmit. The UI should visually indicate that this mode is active.
A short press of the microphone icon triggers manual submit.

I was thinking having this configuration in Settings but this may also work. @timothycarambat any thoughts on this approach?

@yashschandra
Copy link
Contributor Author

@timothycarambat is there any chance a feature like this (or something similar) can be included?

@timothycarambat
Copy link
Member

@therealtimex That kind of UX is ambiguous and is bound to be non-discoverable. Will have to make this a setting in the Voice and Speech area or elsewhere so that we can stop flip-flipping PRs every couple months on this.

@timothycarambat timothycarambat self-assigned this Feb 25, 2025
@timothycarambat timothycarambat added the PR:needs review Needs review by core team label Feb 25, 2025
@therealtimex
Copy link

Agreed, setting is always a safe bet.

@yashschandra
Copy link
Contributor Author

added a checkbox for Autosubmit in Voice and Speech settings section -

output.mp4

@yashschandra
Copy link
Contributor Author

@timothycarambat wondering if this change is good enough to be added? will be very happy to get a feature like this along with all other features people are building here πŸ˜„

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR:needs review Needs review by core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Speech to text confirmation before submission

3 participants