这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@timothycarambat
Copy link
Member

resolves #315

@timothycarambat timothycarambat linked an issue Nov 1, 2023 that may be closed by this pull request
@review-agent-prime
Copy link

The PR looks good overall, but there are a few areas that could be improved:

  1. In frontend/src/components/Modals/MangeWorkspace/Settings/index.jsx, the setTimer function inside the useEffect hook is not cleared when the component is unmounted. This could potentially lead to memory leaks. You should clear the timer using clearTimeout in the cleanup function of the useEffect hook.
useEffect(() => {
  let successTimeout, errorTimeout;

  if (success !== null) {
    successTimeout = setTimeout(() => {
      setSuccess(null);
    }, 3_000);
  }

  if (error !== null) {
    errorTimeout = setTimeout(() => {
      setError(null);
    }, 3_000);
  }

  return () => {
    clearTimeout(successTimeout);
    clearTimeout(errorTimeout);
  };
}, [success, error]);
  1. In server/utils/vectorDbProviders/pinecone/index.js, you have left some debugging console.log statements. It's generally a good practice to remove these before merging to the main branch.

  2. In server/models/workspace.js, you have added similarityThreshold to the list of keys for generic updates. Make sure you have validation in place for this new key to prevent invalid values from being stored in the database.

  3. In server/prisma/migrations/20231101001441_init/migration.sql, you have added a new column similarityThreshold to the workspaces table. Make sure to update any related queries or functions that interact with this table to account for this new column.

  4. In server/utils/vectorDbProviders/pinecone/index.js, the similarityResponse function now takes an additional parameter similarityThreshold. Make sure to update all calls to this function to include this new parameter.

@shatfield4 shatfield4 self-assigned this Nov 1, 2023
@timothycarambat timothycarambat merged commit 88d4808 into master Nov 7, 2023
@timothycarambat timothycarambat deleted the 315-show-citations-based-on-relevancy-score branch November 7, 2023 00:49
franzbischoff referenced this pull request in franzbischoff/anything-llm Nov 7, 2023
* settings for similarity score threshold and prisma schema updated

* prisma schema migration for adding similarityScore setting

* WIP

* Min score default change

* added similarityThreshold checking for all vectordb providers

* linting

---------

Co-authored-by: shatfield4 <seanhatfield5@gmail.com>
franzbischoff referenced this pull request in franzbischoff/anything-llm Nov 7, 2023
* settings for similarity score threshold and prisma schema updated

* prisma schema migration for adding similarityScore setting

* WIP

* Min score default change

* added similarityThreshold checking for all vectordb providers

* linting

---------

Co-authored-by: shatfield4 <seanhatfield5@gmail.com>
timothycarambat added a commit that referenced this pull request Nov 9, 2023
* Using OpenAI API locally

* Infinite prompt input and compression implementation (#332)

* WIP on continuous prompt window summary

* wip

* Move chat out of VDB
simplify chat interface
normalize LLM model interface
have compression abstraction
Cleanup compressor
TODO: Anthropic stuff

* Implement compression for Anythropic
Fix lancedb sources

* cleanup vectorDBs and check that lance, chroma, and pinecone are returning valid metadata sources

* Resolve Weaviate citation sources not working with schema

* comment cleanup

* disable import on hosted instances (#339)

* disable import on hosted instances

* Update UI on disabled import/export

---------

Co-authored-by: timothycarambat <rambat1010@gmail.com>

* Add support for gpt-4-turbo 128K model (#340)

resolves #336
Add support for gpt-4-turbo 128K model

* 315 show citations based on relevancy score (#316)

* settings for similarity score threshold and prisma schema updated

* prisma schema migration for adding similarityScore setting

* WIP

* Min score default change

* added similarityThreshold checking for all vectordb providers

* linting

---------

Co-authored-by: shatfield4 <seanhatfield5@gmail.com>

* rename localai to lmstudio

* forgot files that were renamed

* normalize model interface

* add model and context window limits

* update LMStudio tagline

* Fully working LMStudio integration

---------
Co-authored-by: Francisco Bischoff <984592+franzbischoff@users.noreply.github.com>
Co-authored-by: Timothy Carambat <rambat1010@gmail.com>
Co-authored-by: Sean Hatfield <seanhatfield5@gmail.com>
cabwds pushed a commit to cabwds/anything-llm that referenced this pull request Jul 3, 2025
* settings for similarity score threshold and prisma schema updated

* prisma schema migration for adding similarityScore setting

* WIP

* Min score default change

* added similarityThreshold checking for all vectordb providers

* linting

---------

Co-authored-by: shatfield4 <seanhatfield5@gmail.com>
cabwds pushed a commit to cabwds/anything-llm that referenced this pull request Jul 3, 2025
* Using OpenAI API locally

* Infinite prompt input and compression implementation (Mintplex-Labs#332)

* WIP on continuous prompt window summary

* wip

* Move chat out of VDB
simplify chat interface
normalize LLM model interface
have compression abstraction
Cleanup compressor
TODO: Anthropic stuff

* Implement compression for Anythropic
Fix lancedb sources

* cleanup vectorDBs and check that lance, chroma, and pinecone are returning valid metadata sources

* Resolve Weaviate citation sources not working with schema

* comment cleanup

* disable import on hosted instances (Mintplex-Labs#339)

* disable import on hosted instances

* Update UI on disabled import/export

---------

Co-authored-by: timothycarambat <rambat1010@gmail.com>

* Add support for gpt-4-turbo 128K model (Mintplex-Labs#340)

resolves Mintplex-Labs#336
Add support for gpt-4-turbo 128K model

* 315 show citations based on relevancy score (Mintplex-Labs#316)

* settings for similarity score threshold and prisma schema updated

* prisma schema migration for adding similarityScore setting

* WIP

* Min score default change

* added similarityThreshold checking for all vectordb providers

* linting

---------

Co-authored-by: shatfield4 <seanhatfield5@gmail.com>

* rename localai to lmstudio

* forgot files that were renamed

* normalize model interface

* add model and context window limits

* update LMStudio tagline

* Fully working LMStudio integration

---------
Co-authored-by: Francisco Bischoff <984592+franzbischoff@users.noreply.github.com>
Co-authored-by: Timothy Carambat <rambat1010@gmail.com>
Co-authored-by: Sean Hatfield <seanhatfield5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show citations based on relevancy score

3 participants