Skip too large files to read #3416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So in this case, large files just become invisible? How are you ever supposed to be able to select them to embed afterwards? |
|
The other solution would be to check the size of the file before fs.readFileSync. |
10 tasks
|
Moved to #3497 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
It's not possible to view documents if there is a file bigger than 512 MB in documents.
What is in this change?
Skipping the reading the file when the size is bigger than 512 MB.
Additional Information
By preemptively filtering out oversized files, we improve reliability and maintain system efficiency.
Oversized files can happen due to big PDFs with images.
Developer Validations
yarn lintfrom the root of the repo & committed changes