θΏ™ζ˜―indexlocζδΎ›ηš„ζœεŠ‘οΌŒδΈθ¦θΎ“ε…₯任何密码
Skip to content

Move CTA save buttons to top of workspace setting screens #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Move CTA save buttons to top of workspace setting screens #3613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions frontend/src/pages/WorkspaceSettings/ChatSettings/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import ChatTemperatureSettings from "./ChatTemperatureSettings";
import ChatModeSelection from "./ChatModeSelection";
import WorkspaceLLMSelection from "./WorkspaceLLMSelection";
import ChatQueryRefusalResponse from "./ChatQueryRefusalResponse";
import CTAButton from "@/components/lib/CTAButton";

export default function ChatSettings({ workspace }) {
const [settings, setSettings] = useState({});
Expand Down Expand Up @@ -45,13 +46,20 @@ export default function ChatSettings({ workspace }) {

if (!workspace) return null;
return (
<div id="workspace-chat-settings-container">
<div id="workspace-chat-settings-container" className="relative">
<form
ref={formEl}
onSubmit={handleUpdate}
id="chat-settings-form"
className="w-1/2 flex flex-col gap-y-6"
>
{hasChanges && (
<div className="absolute top-0 right-0">
<CTAButton type="submit">
{saving ? "Updating..." : "Update Workspace"}
</CTAButton>
</div>
)}
<WorkspaceLLMSelection
settings={settings}
workspace={workspace}
Expand All @@ -78,15 +86,6 @@ export default function ChatSettings({ workspace }) {
workspace={workspace}
setHasChanges={setHasChanges}
/>
{hasChanges && (
<button
type="submit"
form="chat-settings-form"
className="w-fit transition-all duration-300 border border-slate-200 px-5 py-2.5 rounded-lg text-white text-sm items-center flex gap-x-2 hover:bg-slate-200 hover:text-slate-800 focus:ring-gray-800"
>
{saving ? "Updating..." : "Update workspace"}
</button>
)}
</form>
</div>
);
Expand Down
20 changes: 10 additions & 10 deletions frontend/src/pages/WorkspaceSettings/GeneralAppearance/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import WorkspaceName from "./WorkspaceName";
import SuggestedChatMessages from "./SuggestedChatMessages";
import DeleteWorkspace from "./DeleteWorkspace";
import WorkspacePfp from "./WorkspacePfp";
import CTAButton from "@/components/lib/CTAButton";

export default function GeneralInfo({ slug }) {
const [workspace, setWorkspace] = useState(null);
Expand Down Expand Up @@ -44,29 +45,28 @@ export default function GeneralInfo({ slug }) {

if (!workspace || loading) return null;
return (
<>
<div className="w-full relative">
<form
ref={formEl}
onSubmit={handleUpdate}
className="w-1/2 flex flex-col gap-y-6"
>
{hasChanges && (
<div className="absolute top-0 right-0">
<CTAButton type="submit">
{saving ? "Updating..." : "Update Workspace"}
</CTAButton>
</div>
)}
<WorkspaceName
key={workspace.slug}
workspace={workspace}
setHasChanges={setHasChanges}
/>
{hasChanges && (
<button
type="submit"
className="transition-all w-fit duration-300 border border-slate-200 px-5 py-2.5 rounded-lg text-white text-sm items-center flex gap-x-2 hover:bg-slate-200 hover:text-slate-800 focus:ring-gray-800"
>
{saving ? "Updating..." : "Update workspace"}
</button>
)}
</form>
<SuggestedChatMessages slug={workspace.slug} />
<WorkspacePfp workspace={workspace} slug={slug} />
<DeleteWorkspace workspace={workspace} />
</>
</div>
);
}
55 changes: 30 additions & 25 deletions frontend/src/pages/WorkspaceSettings/VectorDatabase/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import DocumentSimilarityThreshold from "./DocumentSimilarityThreshold";
import ResetDatabase from "./ResetDatabase";
import VectorCount from "./VectorCount";
import VectorSearchMode from "./VectorSearchMode";
import CTAButton from "@/components/lib/CTAButton";

export default function VectorDatabase({ workspace }) {
const [hasChanges, setHasChanges] = useState(false);
Expand Down Expand Up @@ -35,30 +36,34 @@ export default function VectorDatabase({ workspace }) {

if (!workspace) return null;
return (
<form
ref={formEl}
onSubmit={handleUpdate}
className="w-1/2 flex flex-col gap-y-6"
>
<div className="flex items-start gap-x-5">
<VectorDBIdentifier workspace={workspace} />
<VectorCount reload={true} workspace={workspace} />
</div>
<VectorSearchMode workspace={workspace} setHasChanges={setHasChanges} />
<MaxContextSnippets workspace={workspace} setHasChanges={setHasChanges} />
<DocumentSimilarityThreshold
workspace={workspace}
setHasChanges={setHasChanges}
/>
<ResetDatabase workspace={workspace} />
{hasChanges && (
<button
type="submit"
className="w-fit transition-all duration-300 border border-slate-200 px-5 py-2.5 rounded-lg text-white text-sm items-center flex gap-x-2 hover:bg-slate-200 hover:text-slate-800 focus:ring-gray-800"
>
{saving ? "Updating..." : "Update workspace"}
</button>
)}
</form>
<div className="w-full relative">
<form
ref={formEl}
onSubmit={handleUpdate}
className="w-1/2 flex flex-col gap-y-6"
>
{hasChanges && (
<div className="absolute top-0 right-0">
<CTAButton type="submit">
{saving ? "Updating..." : "Update Workspace"}
</CTAButton>
</div>
)}
<div className="flex items-start gap-x-5">
<VectorDBIdentifier workspace={workspace} />
<VectorCount reload={true} workspace={workspace} />
</div>
<VectorSearchMode workspace={workspace} setHasChanges={setHasChanges} />
<MaxContextSnippets
workspace={workspace}
setHasChanges={setHasChanges}
/>
<DocumentSimilarityThreshold
workspace={workspace}
setHasChanges={setHasChanges}
/>
<ResetDatabase workspace={workspace} />
</form>
</div>
);
}