2964 file type default #2965
Closed
2964 file type default #2965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Works great on my end, exactly what I was needing. |
I dont believe that for a second, this looks great haha. There is a general improvement that I will make on behalf of the PR, but this is great work - will be reviewing soon |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #2964
What is in this change?
Added an experimental setting labeled 'File Type Default' which, when turned on, changes the default behavior when a file being imported can't be recognized, from displaying an error message to treating the file as if it were plain text.
Additional Information
Happy to receive feedback and make changes as needed; I'm not well-versed in javascript or in the frameworks/libraries used here, so most of what I did was based on cloning the live-file-sync functionality.
Developer Validations
yarn lintfrom the root of the repo & committed changes